Repository navigation
fix(onboard): auto-allocate dashboard port on multi-sandbox conflict #2454
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 5 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
196ada1
fix(onboard): auto-allocate dashboard port on multi-sandbox conflict
cjagwani d56382e
Merge branch 'main' into fix/2174-dashboard-port-autoalloc-v2
cjagwani f13c776
fix: apply CodeRabbit auto-fixes
coderabbitai[bot] 20ef745
Merge branch 'main' into fix/2174-dashboard-port-autoalloc-v2
ericksoa d2a74d2
diag: dump fd/process state before exit 0 in survival test
ericksoa d119338
diag v2: save orig stdout/stderr before redirect
ericksoa 2ddd013
diag v3: EXIT trap timestamp to localize the hang
ericksoa d99edca
diag v4: exit 0 + EXIT trap + always-upload artifact
ericksoa 9aaadf9
ci: always-upload sandbox-survival artifact to fix runner-batch flake
ericksoa c7c6125
ci: restore sandbox-survival failure artifact upload
ericksoa 98c41ec
fix(cli): bound OpenShell probes in status and destroy
ericksoa 09f4643
Merge branch 'main' into fix/2174-dashboard-port-autoalloc-v2
ericksoa 46a37cf
Merge branch 'main' into fix/2174-dashboard-port-autoalloc-v2
ericksoa 8bcfb66
fix(onboard): preserve active dashboard forwards on reuse
ericksoa 2d89584
Merge branch 'main' into fix/2174-dashboard-port-autoalloc-v2
ericksoa 7264a1d
test(onboard): allow WSL dashboard forward target
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Print usage text for all
--control-ui-portvalidation failures.Line 83 and Line 88 exit with an error but skip usage output, while other argument-validation failures in this parser print usage. Keeping this consistent improves CLI guidance.
💡 Suggested patch
if (!/^\d+$/.test(raw)) { error(` --control-ui-port '${raw}' must be an integer between 1024 and 65535`); + printOnboardUsage(error, noticeAcceptFlag); exit(1); } const parsed = Number(raw); if (parsed < 1024 || parsed > 65535) { error(` --control-ui-port '${raw}' must be an integer between 1024 and 65535`); + printOnboardUsage(error, noticeAcceptFlag); exit(1); }🤖 Prompt for AI Agents