Repository navigation
fix(channels): prevent Slack auth failure from crashing gateway (#2340) #2355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 8 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
5f44cde
fix(channels): pre-validate Slack auth to prevent gateway crash (#2340)
ericksoa bd61cc1
fix(channels): only disable Slack on definitive auth errors
ericksoa 34009b3
test(e2e): add Slack auth pre-validation to messaging-providers test
ericksoa 70ce88e
fix(e2e): address review feedback on Slack auth e2e tests
ericksoa 2f7ac9b
fix(channels): detect unresolved Slack placeholders in config
ericksoa 9cb663e
fix(e2e): collect entrypoint logs before Slack assertions
ericksoa 3b2e325
test(e2e): check Slack config in Phase 3 while container is alive
ericksoa e335a1b
fix(channels): rewrite placeholder check as grep, add trace logging
ericksoa 21bd3c0
fix(channels): replace config-write approach with NODE_OPTIONS preload
ericksoa 16bd748
fix(channels): catch both sync and async Slack errors in guard
ericksoa 169564b
test(e2e): read gateway.log via openshell exec (root) not SSH (sandbox)
ericksoa 4f12cab
test(e2e): add guard installation diagnostics to Phase 3
ericksoa e378e72
fix(channels): pre-validate Slack auth to prevent gateway crash (#2340)
ericksoa c145798
Merge branch 'main' into fix/slack-auth-crash-2340
ericksoa bdf4f25
fix(channels): replace pre-validation with runtime guard (#2340)
ericksoa 70f2206
Merge branch 'main' into fix/slack-auth-crash-2340
ericksoa cd8ca6b
fix(channels): move guard install after configure_messaging_channels
ericksoa 0dc68d6
fix(channels): degrade gracefully on non-root Slack token override
ericksoa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.