Skip to content

fix(e2e): replace hard exits with skip-and-continue in test-token-rotation.sh #2256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kagura-chen wants to merge 2 commits into from
Closed

fix(e2e): replace hard exits with skip-and-continue in test-token-rotation.sh #2256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c62d0ef
fix(e2e): replace hard exits with skip-and-continue in test-token-rot…
kagura-chen Apr 22, 2026
550502c
fix: distinguish environmental preflight failures as SKIP, gate Phase…
kagura-chen Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
81 changes: 51 additions & 30 deletions test/e2e/test-token-rotation.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,8 +64,8 @@ PASS=0
FAIL=0
SKIP=0
TOTAL=0
INSTALL_OK=1
PREREQS_OK=1
PHASE0_OK=true

pass() {
((PASS++))
Expand Down Expand Up @@ -147,6 +147,11 @@ fi

# ── Helpers ───────────────────────────────────────────────────────

# Detect environmental preflight failures (network, API unreachable)
is_environmental_failure() {
grep -Eqi 'not reachable|unreachable|preflight|network reachability failure' "$1" 2>/dev/null
}

cleanup() {
openshell sandbox delete "$SANDBOX_NAME" 2>/dev/null || true
}
Expand Down Expand Up @@ -198,44 +203,40 @@ fi
if [ $install_exit -eq 0 ]; then
pass "install.sh completed (exit 0)"
else
INSTALL_OK=0
if grep -qE "(Telegram|Discord) network reachability failure" "$INSTALL_LOG" 2>/dev/null; then
skip "install.sh aborted: messaging API unreachable (likely VPN / corporate proxy)"
info "Detected '<provider> network reachability failure' in install log."
if is_environmental_failure "$INSTALL_LOG"; then
skip "Phase 0 skipped — environmental preflight failure (exit $install_exit)"
else
fail "install.sh failed (exit $install_exit)"
fi
info "Last 30 lines of install log:"
tail -30 "$INSTALL_LOG" 2>/dev/null || true
PHASE0_OK=false
fi

# Verify tools are on PATH
if [ "$INSTALL_OK" = "1" ]; then
if [ "$PHASE0_OK" = true ]; then
# Verify tools are on PATH
if ! command -v openshell >/dev/null 2>&1; then
fail "openshell not found on PATH after install"
exit 1
PHASE0_OK=false
else
pass "openshell installed ($(openshell --version 2>&1 || echo unknown))"
fi
pass "openshell installed ($(openshell --version 2>&1 || echo unknown))"

if ! command -v nemoclaw >/dev/null 2>&1; then
if [ "$PHASE0_OK" = true ] && ! command -v nemoclaw >/dev/null 2>&1; then
fail "nemoclaw not found on PATH after install"
exit 1
PHASE0_OK=false
elif [ "$PHASE0_OK" = true ]; then
pass "nemoclaw installed at $(command -v nemoclaw)"
fi
pass "nemoclaw installed at $(command -v nemoclaw)"
fi

if [ "$INSTALL_OK" != "1" ]; then
section "Skipping verification phases — initial install did not complete"
skip "Phase 1: Verify first onboard results"
skip "Phase 2: Re-onboard with rotated TELEGRAM_BOT_TOKEN_B"
skip "Phase 3: Re-onboard with same tokens (after Telegram rotation)"
skip "Phase 4: Re-onboard with rotated DISCORD_BOT_TOKEN_B"
skip "Phase 5: Re-onboard with same tokens (after Discord rotation)"
else
# ── Phase 1: Verify first onboard with token A ──────────────────
# ── Phase 1: Verify first onboard with token A ──────────────────

section "Phase 1: Verify first onboard results"
section "Phase 1: Verify first onboard results"

if [ "$PHASE0_OK" != true ]; then
skip "Phase 1 — skipped (Phase 0 failed)"
else
if openshell sandbox list 2>/dev/null | grep -q "$SANDBOX_NAME"; then
pass "Sandbox $SANDBOX_NAME created and running"
else
Expand Down Expand Up @@ -274,11 +275,17 @@ process.exit('DISCORD_BOT_TOKEN' in h ? 0 : 1);
else
fail "Discord credential hash not found for $SANDBOX_NAME in registry"
fi
fi

# ── Phase 2: Rotate Telegram token only (re-onboard with token B) ─

# ── Phase 2: Rotate Telegram token only (re-onboard with token B) ─
PHASE2_OK=false

section "Phase 2: Re-onboard with rotated TELEGRAM_BOT_TOKEN_B (Discord unchanged)"
section "Phase 2: Re-onboard with rotated TELEGRAM_BOT_TOKEN_B (Discord unchanged)"

if [ "$PHASE0_OK" != true ]; then
skip "Phase 2 — skipped (Phase 0 failed)"
else
export TELEGRAM_BOT_TOKEN="$TELEGRAM_BOT_TOKEN_B"
export DISCORD_BOT_TOKEN="$DISCORD_BOT_TOKEN_A"
# Determinism: clear ambient SLACK_* so onboard doesn't add an extra
Expand All @@ -292,6 +299,8 @@ process.exit('DISCORD_BOT_TOKEN' in h ? 0 : 1);
if [ $onboard_exit -ne 0 ]; then
fail "Phase 2 onboard failed (exit $onboard_exit)"
echo "$ONBOARD_OUTPUT" | tail -30
else
PHASE2_OK=true
fi

if echo "$ONBOARD_OUTPUT" | grep -q "credential(s) rotated"; then
Expand Down Expand Up @@ -334,11 +343,15 @@ process.exit('DISCORD_BOT_TOKEN' in h ? 0 : 1);
else
fail "Sandbox not running after Telegram rotation"
fi
fi

# ── Phase 3: Re-onboard with same tokens (no change) ─────────────
# ── Phase 3: Re-onboard with same tokens (no change) ─────────────

section "Phase 3: Re-onboard with same tokens (no rotation expected)"
section "Phase 3: Re-onboard with same tokens (no rotation expected)"

if [ "$PHASE0_OK" != true ] || [ "$PHASE2_OK" != true ]; then
skip "Phase 3 — skipped (Phase 0 or Phase 2 did not succeed)"
else
ONBOARD_OUTPUT=$(nemoclaw onboard --non-interactive 2>&1)
onboard_exit=$?

Expand All @@ -354,11 +367,15 @@ process.exit('DISCORD_BOT_TOKEN' in h ? 0 : 1);
info "Onboard output:"
echo "$ONBOARD_OUTPUT" | tail -20
fi
fi

# ── Phase 4: Rotate Discord token only (re-onboard with token B) ─
# ── Phase 4: Rotate Discord token only (re-onboard with token B) ─

section "Phase 4: Re-onboard with rotated DISCORD_BOT_TOKEN_B (Telegram unchanged)"
section "Phase 4: Re-onboard with rotated DISCORD_BOT_TOKEN_B (Telegram unchanged)"

if [ "$PHASE0_OK" != true ]; then
skip "Phase 4 — skipped (Phase 0 failed)"
else
export TELEGRAM_BOT_TOKEN="$TELEGRAM_BOT_TOKEN_B"
export DISCORD_BOT_TOKEN="$DISCORD_BOT_TOKEN_B"
# Determinism: clear ambient SLACK_* so onboard doesn't add an extra
Expand Down Expand Up @@ -411,11 +428,15 @@ process.exit('DISCORD_BOT_TOKEN' in h ? 0 : 1);
else
fail "Sandbox not running after Discord rotation"
fi
fi

# ── Phase 5: Re-onboard with same tokens (no change) ─────────────
# ── Phase 5: Re-onboard with same tokens (no change) ─────────────

section "Phase 5: Re-onboard with same tokens (no rotation expected)"
section "Phase 5: Re-onboard with same tokens (no rotation expected)"

if [ "$PHASE0_OK" != true ]; then
skip "Phase 5 — skipped (Phase 0 failed)"
else
ONBOARD_OUTPUT=$(nemoclaw onboard --non-interactive 2>&1)
onboard_exit=$?

Expand Down
Loading