-
Notifications
You must be signed in to change notification settings - Fork 3.1k
docs: refresh for v0.0.20 and document context window, max tokens, and reasoning env vars #2108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| {"name": "nemoclaw", "version": "0.0.18"} | ||
| {"name": "nemoclaw", "version": "0.0.20"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 807
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 2211
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1623
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 817
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 93
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 2793
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1247
🏁 Script executed:
# Look at the start of the test file to understand what 'src' is head -50 test/nemoclaw-start.test.tsRepository: NVIDIA/NemoClaw
Length of output: 2310
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 168
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 2239
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 866
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 758
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
# Check if nemoclaw-start.sh is a static file or generated ls -la scripts/nemoclaw-start.sh file scripts/nemoclaw-start.sh head -20 scripts/nemoclaw-start.shRepository: NVIDIA/NemoClaw
Length of output: 1429
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 2583
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 937
Consider clarifying validation behavior — values are not silently ignored at runtime.
The current text states "Invalid values are ignored, and the default bakes into the image," which accurately describes build-time behavior (in
src/lib/onboard.ts). However, this may mislead readers about runtime validation: at sandbox startup, theapply_model_override()function validates these environment variables and logs detailed errors to stderr if they are invalid, rather than silently ignoring them.For clarity, update the explanation to distinguish build-time and runtime:
You may also clarify the exact validation rules:
NEMOCLAW_CONTEXT_WINDOWandNEMOCLAW_MAX_TOKENSmust be positive integers;NEMOCLAW_REASONINGmust be exactly"true"or"false".🤖 Prompt for AI Agents