Skip to content

fix(onboard): persist model and provider per sandbox in registry (#1689) #1975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 3 commits into from
Apr 16, 2026
Merged

fix(onboard): persist model and provider per sandbox in registry (#1689) #1975

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4f55b93
fix(onboard): persist model and provider per sandbox in registry (#1689)
brandonpelfrey Apr 16, 2026
fe5d7a0
fix(uninstall): replace bash 4+ associative array with portable dedup…
brandonpelfrey Apr 16, 2026
f5b748a
Merge branch 'main' into fix/persist-sandbox-model-provider-1689
ericksoa Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/onboard.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3003,6 +3003,8 @@ async function createSandbox(
const effectiveAgent = agent || agentDefs.loadAgent("openclaw");
registry.registerSandbox({
name: sandboxName,
model: model || null,
provider: provider || null,
gpuEnabled: !!gpu,
agent: agent ? agent.name : null,
agentVersion: fromDockerfile ? null : effectiveAgent.expectedVersion || null,
Expand Down Expand Up @@ -5392,7 +5394,7 @@ async function onboard(opts = {}) {

startRecordedStep("inference", { sandboxName, provider, model });
const inferenceResult = await setupInference(
GATEWAY_NAME,
sandboxName,
model,
provider,
endpointUrl,
Expand Down
21 changes: 13 additions & 8 deletions uninstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,15 +323,20 @@ stop_orphaned_openshell_processes() {
fi
done < <(pgrep "${_pgrep_user[@]}" -x ssh 2>/dev/null || true)

# Deduplicate
local -A seen=()
# Deduplicate (portable — no associative arrays, works on Bash 3.2+)
local -a unique_pids=()
for pid in "${pids[@]}"; do
if [ -z "${seen[$pid]:-}" ]; then
seen[$pid]=1
unique_pids+=("$pid")
fi
done
if [ "${#pids[@]}" -gt 0 ]; then
local _seen=" "
for pid in "${pids[@]}"; do
case "$_seen" in
*" $pid "*) ;;
*)
_seen="$_seen$pid "
unique_pids+=("$pid")
;;
esac
done
fi

if [ "${#unique_pids[@]}" -eq 0 ]; then
info "No orphaned openshell processes found"
Expand Down
Loading