-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(security): redact gateway auth token from console output #1954
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
ColinM-sys
wants to merge
6
commits into
NVIDIA:main
from
ColinM-sys:fix/redact-gateway-token-from-console
Closed
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
7d70feb
fix(security): redact gateway auth token from console output
ColinM-sys cd10417
fix: use actual sandbox name in token retrieval hint per CodeRabbit
ColinM-sys 4e79ae2
Merge branch 'main' into fix/redact-gateway-token-from-console
cjagwani 30fa7aa
merge: resolve conflict with main in agent-onboard.ts
jyaunches e400721
test(onboard): update dashboard UI test to expect redacted token output
jyaunches 63d663a
fix(security): fully redact short tokens and remove arbitrary mask cap
jyaunches File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 50371
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1096
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1208
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 574
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1298
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1957
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 548
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 760
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 606
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 2112
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 206
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 77
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 41
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 5054
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 141
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 309
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 411
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1088
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 344
Pass
forDisplay=truetobuildControlUiUrls()ingetDashboardAccessInfoto prevent token leakage.At line 6193,
getDashboardAccessInfocallsbuildControlUiUrls(token, dashboardPort)without theforDisplayargument, which defaults tofalse. This causes unredacted tokens to be embedded in URLs that are subsequently printed to console at lines 6278–6280. The full token then appears in terminal scrollback and CI/CD logs.Change line 6193 to:
This aligns with the pattern already correctly implemented in
agent-onboard.ts:261where dashboard URLs are printed withforDisplay=true.🤖 Prompt for AI Agents