Skip to content

fix(e2e): use --name flag in landlock sandbox exec (#1851) #1934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericksoa merged 2 commits into from
Apr 16, 2026
Merged

fix(e2e): use --name flag in landlock sandbox exec (#1851) #1934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
60203bd
fix(e2e): use --name flag in landlock sandbox exec (#1851)
ericksoa Apr 16, 2026
74f2585
fix(e2e): use --name flag in sandbox-rebuild exec calls
ericksoa Apr 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/e2e-cloud-experimental/checks/04-landlock-readonly.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ fail_test() {

# Helper: run a command inside the sandbox via openshell
sandbox_exec() {
openshell sandbox exec "$SANDBOX_NAME" -- bash -c "$1" 2>&1
openshell sandbox exec --name "$SANDBOX_NAME" -- bash -c "$1" 2>&1
}

info "Running Landlock read-only checks in sandbox: $SANDBOX_NAME"
Expand Down
6 changes: 3 additions & 3 deletions test/e2e/test-sandbox-rebuild.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,12 +96,12 @@ fi
# ── Step 3: Write marker files into sandbox ─────────────────────────
info "Step 3: Writing marker files into sandbox workspace..."

openshell sandbox exec "$SANDBOX_NAME" -- \
openshell sandbox exec --name "$SANDBOX_NAME" -- \
sh -c "mkdir -p /sandbox/.openclaw-data/workspace && echo '${MARKER_CONTENT}' > ${MARKER_FILE}" \
|| fail "Failed to write marker file"

# Verify the marker file was written
VERIFY=$(openshell sandbox exec "$SANDBOX_NAME" -- cat "$MARKER_FILE" 2>/dev/null || true)
VERIFY=$(openshell sandbox exec --name "$SANDBOX_NAME" -- cat "$MARKER_FILE" 2>/dev/null || true)
[ "$VERIFY" = "$MARKER_CONTENT" ] || fail "Marker file verification failed: got '$VERIFY'"

pass "Marker file written and verified"
Expand Down Expand Up @@ -144,7 +144,7 @@ pass "Rebuild completed"
# ── Step 6: Verify marker files survived ────────────────────────────
info "Step 6: Verifying marker files survived rebuild..."

RESTORED=$(openshell sandbox exec "$SANDBOX_NAME" -- cat "$MARKER_FILE" 2>/dev/null || true)
RESTORED=$(openshell sandbox exec --name "$SANDBOX_NAME" -- cat "$MARKER_FILE" 2>/dev/null || true)
if [ "$RESTORED" = "$MARKER_CONTENT" ]; then
pass "Marker file survived rebuild"
else
Expand Down
Loading