Skip to content

fix(orchestrator): use provider-specific credential environment variable #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dumko2001 wants to merge 1 commit into from
Closed

fix(orchestrator): use provider-specific credential environment variable #191

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions nemoclaw-blueprint/orchestrator/runner.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,11 +194,12 @@ def action_apply(
model: str = inference_cfg.get("model", "")

# Resolve credential from environment
credential_env = inference_cfg.get("credential_env")
target_cred_env = inference_cfg.get("credential_env")
if not target_cred_env:
target_cred_env = "NVIDIA_API_KEY" if provider_type == "nvidia" else "OPENAI_API_KEY"

credential_default: str = inference_cfg.get("credential_default", "")
credential = ""
if credential_env:
credential = os.environ.get(credential_env, credential_default)
credential = os.environ.get(target_cred_env, credential_default)

provider_args = [
"openshell",
Expand All @@ -210,8 +211,10 @@ def action_apply(
provider_type,
]
if credential:
provider_args.extend(["--credential", f"OPENAI_API_KEY={credential}"])
provider_args.extend(["--credential", f"{target_cred_env}={credential}"])
if endpoint:
# Most OpenAI-compatible providers (including NVIDIA integrated)
# use OPENAI_BASE_URL in their internal environment.
provider_args.extend(["--config", f"OPENAI_BASE_URL={endpoint}"])

run_cmd(provider_args, check=False, capture=True)
Expand Down
Loading