fix(plugin): show actual configured model in banner (Closes #24) - #1816
fix(plugin): show actual configured model in banner (Closes #24)#1816WuKongAI-CMU wants to merge 1 commit into
Conversation
When the onboard config file is not available (e.g. inside the sandbox), the plugin banner hardcodes the model as nvidia/nemotron-3-super-120b-a12b and the endpoint as build.nvidia.com regardless of what is actually configured in OpenShell. Query the live OpenShell inference state via `openshell inference get --json` as a fallback before resorting to hardcoded defaults. The probe has a 3-second timeout and falls back to the existing defaults if anything goes wrong. Closes NVIDIA#24
|
This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughAdded a Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
## Summary When the onboard config file is not available (e.g. when running inside the sandbox), the plugin banner in \`nemoclaw/src/index.ts\` hardcodes the model as \`nvidia/nemotron-3-super-120b-a12b\` and the endpoint as \`build.nvidia.com\` regardless of what is actually configured in OpenShell. This PR queries the live OpenShell inference state via \`openshell inference get --json\` as a fallback before resorting to hardcoded defaults. The probe has a 3-second timeout and falls back cleanly to the existing defaults if anything goes wrong. Closes #24. ## Changes - \`nemoclaw/src/index.ts\` — add \`probeOpenShellInference()\` helper and wire it into banner resolution after onboard config lookup, before hardcoded defaults ## Test plan - [x] Minimal diff, existing defaults preserved as final fallback - [x] 3s timeout prevents banner from hanging on a slow/broken openshell binary - [x] No new runtime dependencies (uses stdlib \`node:child_process\`) (Resubmitting — prior PR #1816 was auto-closed by the 10-PR-cap check when our open PR count briefly exceeded the limit; we're now under the cap.) 🤖 Generated with [Claude Code](https://claude.com/claude-code) <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit * **Bug Fixes** * Improved configuration resolution for model provider, endpoint, and model: the app now prefers onboard settings, probes live inference state to fill missing values, and falls back to defaults for more reliable initialization and registration. * **Tests** * Added test coverage verifying fallback to probed inference values and confirming probe details are logged during registration. <!-- end of auto-generated comment: release notes by coderabbit.ai --> Signed-off-by: Intern Dev <dev@wukongai.io> --------- Co-authored-by: Intern Dev <dev@wukongai.io> Co-authored-by: Carlos Villela <cvillela@nvidia.com>
Summary
When the onboard config file is not available (e.g. when running inside the sandbox), the plugin banner in `nemoclaw/src/index.ts` hardcodes the model as `nvidia/nemotron-3-super-120b-a12b` and the endpoint as `build.nvidia.com` regardless of what is actually configured in OpenShell.
This PR queries the live OpenShell inference state via `openshell inference get --json` as a fallback before resorting to hardcoded defaults. The probe has a 3-second timeout and falls back cleanly to the existing defaults if anything goes wrong.
Closes #24.
Changes
Test plan
🤖 Generated with Claude Code
Summary by CodeRabbit