fix(nim): bound curl health probes with --max-time

[WuKongAI-CMU]

Summary

The NIM health probe loop and nimStatusByName() use curl -sf without a timeout in src/lib/nim.ts. On a hung or silently-dropping NIM endpoint, the curl call can block indefinitely, stalling onboard/waitForNimHealth and CLI status.

Add --max-time 5 to both probe calls so each attempt times out cleanly and the outer retry loop can make progress.

Changes

• src/lib/nim.ts:212 — waitForNimHealth loop probe now curl -sf --max-time 5 ...
• src/lib/nim.ts:265 — nimStatusByName health probe now curl -sf --max-time 5 ...

Test plan

• Code review — minimal diff, existing retry/interval behavior preserved
• 5s timeout chosen to fit under the 5s inter-retry sleep interval in waitForNimHealth
• No new dependencies, no test changes required (probes are shelled out)

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Improved health check responsiveness by adding a timeout mechanism to ensure faster detection and recovery from unresponsive health checks.

[github-actions]

This repository limits contributors to 10 open pull requests. Please close or merge existing PRs before opening new ones.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 23bfc73d-19f6-4147-a094-52d87d87112c

📥 Commits

Reviewing files that changed from the base of the PR and between d4aac4c and fae358d.

📒 Files selected for processing (1)

• src/lib/nim.ts

---

📝 Walkthrough

Walkthrough

Added a --max-time 5 timeout constraint to curl health-check commands in NIM probing functions (waitForNimHealth and nimStatusByName). This ensures health checks complete within 5 seconds, preventing indefinite hangs during container health verification.

Changes

Cohort / File(s)	Summary
NIM Health Probe Timeout src/lib/nim.ts	Added --max-time 5 flag to curl commands in waitForNimHealth and nimStatusByName functions to enforce a 5-second timeout on health-check requests.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

Poem

🐰 A timeout here, a timeout there,
Five seconds now—the health checks care!
No more infinite waiting games,
Our probes hop faster, earning their names!

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}