-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(security): drop cap_fowner and tighten sandbox policy #1796
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
+44
−74
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
f92689e
fix(security): drop cap_fowner from sandbox bounding set (#797)
wbrom42 2552f8a
fix(security): remove unused endpoints from base sandbox policy
wbrom42 472c706
chore: bump openclaw dependency to ^2026.4.9
wbrom42 2873218
docs: add security notes for upstream openclaw vuln tracking
wbrom42 9d0026e
fix(security): harden /tmp log init against symlink hijacking
wbrom42 37fbc9d
docs: fix markdown structure and casing in SECURITY_NOTES
wbrom42 cd1589a
merge(pr): resolve #1796 against origin/main
cv File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| <!-- SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. --> | ||
| <!-- SPDX-License-Identifier: Apache-2.0 --> | ||
|
|
||
| # Security Notes | ||
|
|
||
| ## Upstream vulnerability snapshot | ||
|
|
||
| This note records a review snapshot for OpenClaw@2026.4.11 transitive | ||
| dependencies (Lark SDK `@larksuiteoapi/node-sdk` and Discord `axios`/`tar` | ||
| deps). | ||
|
|
||
| **Mitigation:** The tightened baseline sandbox policy blocks direct access to | ||
| Lark and Discord endpoints by default. | ||
|
|
||
| **Action:** Revisit when OpenClaw ships `axios`/`tar` dependency bumps. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 129
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 84
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 613
🏁 Script executed:
Repository: NVIDIA/NemoClaw
Length of output: 1433
Use
mv -Tfor the final log-path replace.Lines 957 and 962 use plain
mv. If the destination is recreated as a directory between therm -fstep and the rename,mvwill move the temp file into that directory instead of replacing the pathname, which weakens the TOCTOU hardening here.Suggested fix
📝 Committable suggestion
🤖 Prompt for AI Agents