Skip to content

fix(installer): list full NEMOCLAW_PROVIDER values in help - #1794

Merged
cv merged 2 commits into
NVIDIA:mainfrom
WilliamK112:fix/install-help-provider-values
Apr 14, 2026
Merged

fix(installer): list full NEMOCLAW_PROVIDER values in help#1794
cv merged 2 commits into
NVIDIA:mainfrom
WilliamK112:fix/install-help-provider-values

Conversation

@WilliamK112

@WilliamK112 WilliamK112 commented Apr 12, 2026

Copy link
Copy Markdown
Contributor

Summary

  • update installer help to list the full supported NEMOCLAW_PROVIDER values
  • document the cloud -> build and nim -> nim-local aliases
  • add coverage for both bootstrap and payload installer help output

Testing

  • npm test -- test/install-preflight.test.ts

Related

Summary by CodeRabbit

  • Documentation

    • Updated installation help text to document expanded list of supported providers and backward-compatible aliases.
  • Tests

    • Added test coverage for the updated provider documentation and aliases.

Signed-off-by: WilliamK112 164879897+WilliamK112@users.noreply.github.com

@coderabbitai

coderabbitai Bot commented Apr 12, 2026

Copy link
Copy Markdown
Contributor
📝 Walkthrough

Walkthrough

Updated install.sh help text to expand the supported NEMOCLAW_PROVIDER values from four to nine options, adding explicit alias mappings for backward compatibility. Extended test coverage to verify the expanded provider list and aliases are correctly displayed.

Changes

Cohort / File(s) Summary
Help Text Expansion
scripts/install.sh
Expanded NEMOCLAW_PROVIDER help documentation from `cloud
Test Coverage
test/install-preflight.test.ts
Extended --help test assertions to validate the complete provider list output and alias mapping text. Added new direct installer script test case asserting the same provider set and zero exit status.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Help text grows with providers anew,
Build, openai, anthropic too!
Cloud and nim find their new names,
Aliases keep the old ways the same,
Tests ensure the truth rings clear and true! ✨

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title 'fix(installer): list full NEMOCLAW_PROVIDER values in help' accurately describes the main change: updating installer help output to display all supported provider values.
Linked Issues check ✅ Passed The PR successfully addresses issue #1766 by updating help text to list all valid NEMOCLAW_PROVIDER values (build, openai, anthropic, anthropicCompatible, gemini, ollama, custom, nim-local, vllm) and documenting aliases.
Out of Scope Changes check ✅ Passed All changes are directly related to the linked issue: installer help text updates and corresponding test coverage for the new provider list and aliases.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@wscurran

Copy link
Copy Markdown
Contributor

✨ Thanks for submitting this PR, which proposes a way to improve the clarity of the installer help text by listing all supported provider values.


Possibly related open issues:

@prekshivyas prekshivyas self-assigned this Apr 14, 2026
@prekshivyas
prekshivyas requested a review from cv April 14, 2026 17:03
@cv cv added the v0.0.16 label Apr 14, 2026
@cv
cv merged commit 1247801 into NVIDIA:main Apr 14, 2026
12 of 13 checks passed
@wscurran wscurran added area: docs Documentation, examples, guides, or docs build bug-fix PR fixes a bug or regression and removed documentation labels Jun 3, 2026
@wscurran wscurran added NV QA Bugs found by the NVIDIA QA Team VDR Linked to VDR finding labels Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: docs Documentation, examples, guides, or docs build bug-fix PR fixes a bug or regression NV QA Bugs found by the NVIDIA QA Team VDR Linked to VDR finding

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[All Platforms] install.sh help lists only 4 NEMOCLAW_PROVIDER values

4 participants