Skip to content

fix(onboard): skip CoreDNS patching on WSL2 to fix sandbox DNS #1207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cv merged 1 commit into from
Mar 31, 2026
Merged

fix(onboard): skip CoreDNS patching on WSL2 to fix sandbox DNS #1207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions bin/lib/platform.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,12 @@ function isUnsupportedMacosRuntime(runtime, opts = {}) {
return platform === "darwin" && runtime === "podman";
}

function shouldPatchCoredns(runtime) {
// k3s-inside-Docker has broken DNS forwarding on all platforms
// (systemd-resolved, Docker Desktop DNS, Colima DNS).
// Always patch CoreDNS to use a non-loopback upstream.
function shouldPatchCoredns(runtime, opts = {}) {
// k3s CoreDNS defaults to a loopback DNS that pods can't reach.
// Patch it to use a real upstream on most Docker-based runtimes.
// On WSL2, the host DNS is not routable from k3s pods - skip the
// patch and let setup-dns-proxy.sh handle resolution instead.
if (isWsl(opts)) return false;
return runtime !== "unknown";
}

Expand Down
Loading