fix(ci): trigger main publication for lifecycle changes - #11663
fix(ci): trigger main publication for lifecycle changes#11663apurvvkumaria wants to merge 2 commits into
Conversation
Signed-off-by: Apurv Kumaria <akumaria@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 4 remain after this review. 📝 WalkthroughWalkthroughThe workflows now trigger for gateway runtime-start and lifecycle fixture changes. Tests verify the managed-image pull-request and base-image push path filters. ChangesWorkflow Trigger Coverage
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to Workflow trigger coverage is expanded for the listed fixtures, with no concrete merge-blocking risk established. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit f8feb16 in the TypeScript / code-coverage/cliThe overall line coverage in commit f8feb16 in the Show a line coverage summary of the most impacted files.
Updated |
Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
|
PR Review Advisor finished for commit |
Outcome
Lifecycle recovery changes now run the real all-agent activation gate before merge and the trusted image publication workflow after merge. Changes to the gateway recovery helper are covered by the same selectors.
Reason
PR #11641 added the lifecycle fixture to the managed-image pull request selector, but the main publication selector still omitted it. Both selectors also omitted the gateway recovery helper imported by that fixture. A lifecycle-only or helper-only change could therefore skip required managed-image validation or post-merge publication.
Related issues
Changes
This changes trigger selection only. It does not change workflow jobs, permissions, credentials, publication logic, or supported runtime behavior.
Verification
npx vitest run --project integration test/inference/managed/managed-image-publication-workflow.test.ts— 36 tests passed.npx vitest run --project e2e-support test/e2e/support/gateway-runtime-start.test.ts test/e2e/support/e2e-phase-lifecycle.test.ts test/e2e/support/base-image-publication.test.ts— 123 tests passed.3be7bb5fe3cd19ae3e22f436e083cdd57390e828as Verified.Review notes
Signed-off-by: Apurv Kumaria akumaria@nvidia.com
Summary by CodeRabbit