fix(advisor): support pinned OpenShell exec

test/automation/pull-requests/pr-review-advisor-openshell.test.ts

@@ -571,14 +571,20 @@ describe("PR review advisor OpenShell wrapper", () => {
     expect(child.stderr).toBe("");
   });
 
-  it("permits only the pinned image login files required by stable OpenShell exec", () => {
-    const policy = YAML.parse(
+  it("permits only the pinned image login files in managed review policies (#10947)", () => {
+    const advisorPolicy = YAML.parse(
       fs.readFileSync("tools/pr-review-advisor/openshell-policy.yaml", "utf8"),
     ) as {
       filesystem_policy: { read_only: string[]; read_write: string[] };
     };
+    const postMergePolicy = YAML.parse(
+      fs.readFileSync("tools/post-merge-docs/review-policy.yaml", "utf8"),
+    ) as {
+      filesystem_policy: { read_only: string[]; read_write: string[] };
+    };
+    const loginFiles = ["/sandbox/.bashrc", "/sandbox/.profile"];
 
-    expect(policy.filesystem_policy).toEqual({
+    expect(advisorPolicy.filesystem_policy).toEqual({
       include_workdir: false,
       read_only: [
         "/usr/bin",
@@ -594,6 +600,12 @@ describe("PR review advisor OpenShell wrapper", () => {
       ],
       read_write: ["/dev", "/sandbox/pr-review-advisor-runtime"],
     });
+    expect(
+      advisorPolicy.filesystem_policy.read_only.filter((entry) => entry.startsWith("/sandbox/.")),
+    ).toEqual(loginFiles);
+    expect(
+      postMergePolicy.filesystem_policy.read_only.filter((entry) => entry.startsWith("/sandbox/.")),
+    ).toEqual(loginFiles);
   });
 
   it.each([
@@ -1227,6 +1239,18 @@ describe("PR review advisor OpenShell wrapper", () => {
         "HEAD",
       ]),
     );
+    expect(runArgs).not.toContain("--no-login-shell");
+    const commandBoundaryIndex = runArgs.indexOf("--");
+    expect(runArgs.slice(commandBoundaryIndex)).toEqual([
+      "--",
+      "/usr/bin/node",
+      "--no-warnings",
+      "/advisor/tools/pr-review-advisor/run-specialist.mts",
+      "--base",
+      "target/base",
+      "--head",
+      "HEAD",
+    ]);
     expect(runArgs.join("\n")).not.toContain("github-host-secret");
     expect(runArgs.join("\n")).not.toContain("model-host-secret");
     expect(runArgs.join("\n")).not.toContain("advisor-host-secret");

test/generation/post-merge-docs.test.ts

@@ -1056,6 +1056,10 @@ describe("post-merge documentation runner", () => {
       },
     });
     expect(state.createArgs).not.toContain("--upload");
+    const policyIndex = state.createArgs.indexOf("--policy");
+    expect(state.createArgs[policyIndex + 1]).toBe(
+      path.join(input.env.TRUSTED_CHECKOUT, "tools/post-merge-docs/review-policy.yaml"),
+    );
     expect(state.createArgs.slice(-6)).toEqual([
       "--",
       "/usr/bin/git",

tools/post-merge-docs/review-policy.yaml

@@ -10,6 +10,9 @@ filesystem_policy:
     - /usr/lib
     - /usr/share/git-core
     - /etc
+    # OpenShell 0.0.116 runs sandbox exec through bash -lc. The pinned image owns these files.
+    - /sandbox/.bashrc
+    - /sandbox/.profile
     - /sandbox/repo
     - /sandbox/config
   read_write:

tools/pr-review-advisor/openshell-policy.yaml

@@ -10,6 +10,7 @@ filesystem_policy:
     - /usr/lib
     - /usr/share/git-core
     - /etc
+    # OpenShell 0.0.116 runs sandbox exec through bash -lc. The pinned image owns these files.
     - /sandbox/.bashrc
     - /sandbox/.profile
     - /advisor