fix(test): let the host timeout own supervisor cleanup

[jyaunches]

Outcome

The launch supervisor timeout test now lets the host timeout terminate the command before the fixture's internal deadline expires.

Reason

The fixture's two-second session budget could expire before the 2.5-second host timeout. This caused fixture.result.timedOut to be false.
The same assertion failed on main CI and blocked PR #11487.

Changes

Give supervisor-timeout the existing ten-second session budget used by restored-canonical-timeout. Keep the host timeout and all descendant-cleanup assertions unchanged.
No production code, retry policy, or new mechanism changes.

Verification

• Linux, Node 22.23.2 container with --init: npx vitest run --project e2e-support test/e2e/support/launch-agent-turn.test.ts -t "host command times out" --reporter=verbose — passed; 1 test passed, 43 deselected. This ran before rebase; the test file is unchanged by rebase.
• macOS: npx vitest run --project e2e-support test/e2e/support/launch-agent-turn.test.ts — 6 passed, 38 Linux-only tests skipped.
• npm --prefix nemoclaw run build and npm run build:cli — passed.
• NODE_OPTIONS=--max-old-space-size=5120 npm run validate:pr — passed for b1aeedef5b80ae061745a502eb5938b755526f43, with canonical validation base 41c5625e8b831ed213cd5c381385973adc58659c.
• Diff review found no secrets, API keys, or credentials.

Review notes

Local Advisor sandbox creation is unavailable in this shepherd session. Alternative review completed for the one-line diff: correctness, unchanged cleanup assertions, sibling timeout budgets, and security boundaries were checked. This is self-review, not independent Advisor clearance. Hosted checks and review remain pending.
An initial Linux container without an init process retained zombie descendants; the corrected container passed the affected test. The full Linux suite did not complete, so no full-suite pass is claimed.

---

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

• Bug Fixes
  • Updated the supervisor timeout test scenario to use a 10-second launch session budget, aligning it with the restored canonical timeout scenario.
  • Other timeout modes and default budgets remain unchanged.

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: a062f4c7-9af8-4e85-abac-7bd798cd4474

📥 Commits

Reviewing files that changed from the base of the PR and between 70cfff5 and b1aeede.

📒 Files selected for processing (1)

• test/e2e/support/launch-agent-turn.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 9 remain after this review.

---

📝 Walkthrough

Walkthrough

The supervisor-timeout fixture now uses a 10-second launch session budget. Other timeout modes and default budgets remain unchanged.

Changes

Timeout fixture configuration

Layer / File(s)	Summary
Supervisor timeout budget test/e2e/support/launch-agent-turn.test.ts	The supervisor-timeout fixture now uses a 10-second session budget.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Other

Suggested reviewers: senthilr-nv

Merge Risk: ⚪ Minimal · up to b1aee

The test-only timeout adjustment preserves the host-timeout and cleanup assertions without introducing production risk.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly describes the test fix: the host timeout now controls supervisor cleanup. It matches the stated objective and is concise.

• Fix all pre-merge checks with AI

✨ Finishing Touches 💡 2

📝 Generate docstrings 💡

• Create stacked PR
• Commit on current branch

🛠️ Fix failing CI checks 💡

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch codex/fix-launch-supervisor-timeout

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-code-quality]

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit b1aeede in the codex/fix-launch-sup... branch remains at 96%, unchanged from commit 70cfff5 in the main branch.

Show a line coverage summary of the most impacted files.

File	main 70cfff5	codex/fix-launch-sup... b1aeede	+/-
nemoclaw/src/bl...ate-networks.ts	94%	89%	-5%

TypeScript / code-coverage/cli

The overall line coverage in commit b1aeede in the codex/fix-launch-sup... branch remains at 83%, unchanged from commit 70cfff5 in the main branch.

Show a line coverage summary of the most impacted files.

File	main 70cfff5	codex/fix-launch-sup... b1aeede	+/-
src/lib/actions...dbox/destroy.ts	92%	89%	-3%
src/lib/actions...oy-execution.ts	94%	91%	-3%
src/lib/domain/...ycle/options.ts	87%	85%	-2%
src/lib/actions...-add-restart.ts	31%	30%	-1%
src/lib/onboard...uild-context.ts	75%	75%	0%
src/lib/actions...confirmation.ts	69%	69%	0%
src/lib/domain/...dbox/destroy.ts	97%	97%	0%
src/lib/sandbox...rce-identity.ts	82%	82%	0%
src/lib/onboard...eway-process.ts	89%	90%	+1%
src/lib/actions...oy-preflight.ts	83%	84%	+1%

---

_{Updated September 11, 2026 17:12 UTC}

[jyaunches]

@coderabbitai review

[coderabbitai]

✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.