fix(e2e): prepare attached Ollama for export - #11550
Draft
sandl99 wants to merge 6 commits into
Draft
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Signed-off-by: San Dang <sdang@nvidia.com>
Signed-off-by: San Dang <sdang@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
The attached Ollama export E2E prepares a ready daemon with an installed model, reuses the host's shared proxy port, and stops the competing installer service before export qualification.
Reason
The fixture treated a two-second curl startup timeout as terminal. Its fresh daemon also had an empty model cache, and it requested a different proxy port from the preceding GPU scenarios. The existing host-wide proxy contract rejects that change.
E2E root cause: attached-daemon export fixture / incomplete startup preparation.
The original failure stopped at readiness. Current validation completes fixture preparation and onboarding, then fails at provider metadata verification. The target is not yet green.
Related issues
Refs #11435. Repairs the export E2E introduced by #11473.
Changes
qwen3.5:9bdirectly into the attached daemon on11439. Inherit the target'sPROXY_PORTand verify it in the export.The polling limits, per-attempt artifacts, assertion budget, export checks, and stopped-backend refusal remain intact. Mutations are not retried. No product code changes relative to main. General nondefault-port model downloads remain outside this export-fixture repair.
Verification
Current commit:
b3ccf627af3b1b253563962b176efcfb1b48dab3, including maine4e6391870bef3834cd30cdd997529e5361f89a5through a clean signed merge.7, 28, 0; model preparation, onboarding, and service shutdown succeed. First export fails withThe live inference provider metadata could not be read or verified.All registered cleanup actions pass; stopped-backend refusal is not reached.setup-nim-flow-vllm-resume.test.tstest for a pinned provider exceeded five seconds in shard 6. The exact test passes locally in 291 ms; no GitHub rerun or timeout increase was applied. The CLI aggregate and overall check inherit that failure.Review notes
Main includes #11601, which resolves the preceding SDK sandbox-inventory failure tracked by #11421. The rerun reaches the later provider-metadata stage; its precise failing sub-check is not yet identified. No export assertion is relaxed, and no successful export is claimed.
Advisor run 34680869998 is skipped because CI is red. It produced no current-commit specialist review. CodeRabbit skips draft PRs. There are no submitted reviews or inline threads, and no clean Advisor review or waiver is claimed.
Signed-off-by: San Dang sdang@nvidia.com