Skip to content

fix(test): remove duplicate host fence imports - #11519

Merged
ericksoa merged 1 commit into
mainfrom
codex/fix-main-host-fence-duplicate-import
Sep 11, 2026
Merged

fix(test): remove duplicate host fence imports#11519
ericksoa merged 1 commit into
mainfrom
codex/fix-main-host-fence-duplicate-import

Conversation

@cjagwani

@cjagwani cjagwani commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

Outcome

Restore CLI typechecking on main by removing two duplicate test-helper imports. Runtime behavior is unchanged.

Reason

#11480 re-added imports that were already introduced by #11506, causing deterministic duplicate-identifier failures in both runtime-provider test files.

Related issues

Refs #11480
Refs #11506

Changes

  • Remove the duplicate withCurrentPortableHostFence import from the Podman test.
  • Remove the duplicate withCurrentPortableHostFence import from the runtime-provider contract test.

Verification

  • Affected runtime-provider and lifecycle-lock suites — 102/102 passed.
  • NODE_OPTIONS=--max-old-space-size=8192 npm run typecheck:cli — passed.
  • NODE_OPTIONS=--max-old-space-size=8192 npm run validate:pr — passed.
  • Diff reviewed — no secrets, API keys, credentials, or production-code changes.

Review notes

This is an isolated two-line test correction based on current main; independent review and normal required CI remain required.


Signed-off-by: Charan Jagwani cjagwani@nvidia.com

Summary by CodeRabbit

  • Chores
    • Removed unused test imports.

Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
@cjagwani cjagwani self-assigned this Sep 11, 2026
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 28b8d376-0244-4160-a72f-7ff7a79a0f91

📥 Commits

Reviewing files that changed from the base of the PR and between 08f3271 and a6e4c2a.

📒 Files selected for processing (2)
  • src/lib/onboard/runtime-provider/podman.test.ts
  • src/lib/onboard/runtime-provider/runtime-provider-contract.test.ts
💤 Files with no reviewable changes (2)
  • src/lib/onboard/runtime-provider/runtime-provider-contract.test.ts
  • src/lib/onboard/runtime-provider/podman.test.ts

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The change removes unused withCurrentPortableHostFence imports from two runtime-provider test files. Existing test behavior remains unchanged.

Changes

Runtime provider test cleanup

Layer / File(s) Summary
Remove unused test imports
src/lib/onboard/runtime-provider/podman.test.ts, src/lib/onboard/runtime-provider/runtime-provider-contract.test.ts
Removed unused withCurrentPortableHostFence imports. Existing test usage remains unchanged.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Bug fix

Suggested reviewers: apurvvkumaria

Merge Risk: ⚪ Minimal · up to a6e4c

The cleanup removes duplicate test imports without changing runtime behavior. No merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the main change: removing duplicate host fence imports from tests. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/fix-main-host-fence-duplicate-import

Comment @coderabbitai help to get the list of available commands.

@github-code-quality

github-code-quality Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit a6e4c2a in the codex/fix-main-host-... branch remains at 96%, unchanged from commit 08f3271 in the main branch.

TypeScript / code-coverage/cli

The overall line coverage in commit a6e4c2a in the codex/fix-main-host-... branch remains at 83%, unchanged from commit 2f535d3 in the main branch.

Show a line coverage summary of the most impacted files.
File main 2f535d3 codex/fix-main-host-... a6e4c2a +/-
src/lib/onboard...uild-context.ts 75% 75% 0%
src/lib/sandbox...rce-identity.ts 82% 82% 0%
src/lib/onboard...outer-python.ts 84% 96% +12%
src/lib/onboard...uter-command.ts 52% 65% +13%

Updated September 11, 2026 04:24 UTC

@github-actions

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit a6e4c2a. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@cjagwani
cjagwani marked this pull request as ready for review September 11, 2026 04:32
@ericksoa
ericksoa merged commit a83f631 into main Sep 11, 2026
90 checks passed
@ericksoa
ericksoa deleted the codex/fix-main-host-fence-duplicate-import branch September 11, 2026 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants