fix(test): remove duplicate host fence imports - #11519
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe change removes unused ChangesRuntime provider test cleanup
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~2 minutes Change: Bug fix Suggested reviewers: Merge Risk: ⚪ Minimal · up to The cleanup removes duplicate test imports without changing runtime behavior. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit a6e4c2a in the TypeScript / code-coverage/cliThe overall line coverage in commit a6e4c2a in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit |
Outcome
Restore CLI typechecking on
mainby removing two duplicate test-helper imports. Runtime behavior is unchanged.Reason
#11480 re-added imports that were already introduced by #11506, causing deterministic duplicate-identifier failures in both runtime-provider test files.
Related issues
Refs #11480
Refs #11506
Changes
withCurrentPortableHostFenceimport from the Podman test.withCurrentPortableHostFenceimport from the runtime-provider contract test.Verification
NODE_OPTIONS=--max-old-space-size=8192 npm run typecheck:cli— passed.NODE_OPTIONS=--max-old-space-size=8192 npm run validate:pr— passed.Review notes
This is an isolated two-line test correction based on current
main; independent review and normal required CI remain required.Signed-off-by: Charan Jagwani cjagwani@nvidia.com
Summary by CodeRabbit