-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix(portable): unify lifecycle lock authority #11490
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,214 @@ | ||
| // SPDX-FileCopyrightText: Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| import fs from "node:fs"; | ||
| import os from "node:os"; | ||
| import path from "node:path"; | ||
|
|
||
| import { afterEach, beforeEach, describe, expect, it, vi } from "vitest"; | ||
|
|
||
| import * as receiptAuthority from "../../../onboard/experimental/hermes-portable-receipt"; | ||
| import { | ||
| portableLifecycleLockOptions, | ||
| resolveHermesPortableLifecycleLockOptions, | ||
| } from "../../../onboard/experimental/portable-lifecycle-lock"; | ||
| import { isMcpLifecycleLockHeld } from "../../../state/mcp-lifecycle-lock-acquisition"; | ||
| import { | ||
| portableHostFencePath, | ||
| withCurrentPortableHostFence, | ||
| } from "../../../state/portable-uninstall-retirement"; | ||
| import { withSandboxLifecycleLock, withSandboxLifecycleLockSync } from "./lock"; | ||
|
|
||
| describe("Portable-aware sandbox lifecycle lock", () => { | ||
| let homeDir: string; | ||
|
|
||
| beforeEach(() => { | ||
| homeDir = fs.mkdtempSync(path.join(os.tmpdir(), "nemoclaw-portable-lifecycle-lock-")); | ||
| vi.stubEnv("HOME", homeDir); | ||
| vi.stubEnv("NEMOCLAW_GATEWAY_PORT", "18080"); | ||
| vi.spyOn(receiptAuthority, "hasHermesPortableReceiptCandidate").mockReturnValue(true); | ||
| }); | ||
|
|
||
| afterEach(() => { | ||
| vi.restoreAllMocks(); | ||
| vi.unstubAllEnvs(); | ||
| fs.rmSync(homeDir, { recursive: true, force: true }); | ||
| }); | ||
|
|
||
| it("reuses one host-scoped lock through asynchronous and synchronous lifecycle layers", async () => { | ||
| const portableStateDir = portableLifecycleLockOptions(process.env).stateDir; | ||
| const gatewayStateDir = path.join(homeDir, ".nemoclaw", "gateways", "18080", "state"); | ||
|
|
||
| await withSandboxLifecycleLock("alpha", async () => { | ||
| expect(fs.existsSync(portableHostFencePath(homeDir))).toBe(true); | ||
| expect(isMcpLifecycleLockHeld("alpha", portableStateDir)).toBe(true); | ||
| expect(isMcpLifecycleLockHeld("alpha", gatewayStateDir)).toBe(false); | ||
|
|
||
| withSandboxLifecycleLockSync("alpha", () => { | ||
| expect(isMcpLifecycleLockHeld("alpha", portableStateDir)).toBe(true); | ||
| expect(isMcpLifecycleLockHeld("alpha", gatewayStateDir)).toBe(false); | ||
| }); | ||
|
|
||
| await withSandboxLifecycleLock("alpha", () => { | ||
| expect(isMcpLifecycleLockHeld("alpha", portableStateDir)).toBe(true); | ||
| expect(isMcpLifecycleLockHeld("alpha", gatewayStateDir)).toBe(false); | ||
| }); | ||
| }); | ||
|
|
||
| expect(fs.existsSync(portableHostFencePath(homeDir))).toBe(false); | ||
| }); | ||
|
|
||
| it("selects host receipt state only for a Hermes Portable candidate", () => { | ||
| const env = { HOME: homeDir, NEMOCLAW_GATEWAY_PORT: "18080" }; | ||
|
|
||
| expect(resolveHermesPortableLifecycleLockOptions("alpha", env, () => true)).toEqual({ | ||
| stateDir: path.join(homeDir, ".nemoclaw", "state"), | ||
| }); | ||
| expect(resolveHermesPortableLifecycleLockOptions("alpha", env, () => false)).toBeUndefined(); | ||
| }); | ||
|
|
||
| it("rejects every direct synchronous operation without the host fence", () => { | ||
| expect(() => withSandboxLifecycleLockSync("alpha", () => undefined)).toThrow( | ||
| "Portable host authority mutation requires the current HOME fence", | ||
| ); | ||
| }); | ||
|
|
||
| it("classifies absent-to-Portable transitions after acquiring the host fence", async () => { | ||
| vi.restoreAllMocks(); | ||
| vi.resetModules(); | ||
| const [freshReceiptAuthority, freshPortableLock, freshAcquisition, freshHostFence, freshLock] = | ||
| await Promise.all([ | ||
| import("../../../onboard/experimental/hermes-portable-receipt"), | ||
| import("../../../onboard/experimental/portable-lifecycle-lock"), | ||
| import("../../../state/mcp-lifecycle-lock-acquisition"), | ||
| import("../../../state/portable-uninstall-retirement"), | ||
| import("./lock"), | ||
| ]); | ||
| let candidate = false; | ||
| vi.spyOn(freshReceiptAuthority, "hasHermesPortableReceiptCandidate").mockImplementation( | ||
| () => candidate, | ||
| ); | ||
| let releaseTransition!: () => void; | ||
| const transitionBlocked = new Promise<void>((resolve) => { | ||
| releaseTransition = resolve; | ||
| }); | ||
| let transitionStarted!: () => void; | ||
| const transitionEntered = new Promise<void>((resolve) => { | ||
| transitionStarted = resolve; | ||
| }); | ||
| const transition = freshHostFence.withCurrentPortableHostFence(async () => { | ||
| transitionStarted(); | ||
| await transitionBlocked; | ||
| candidate = true; | ||
| }); | ||
| let startOperation!: () => void; | ||
| const operationStart = new Promise<void>((resolve) => { | ||
| startOperation = resolve; | ||
| }); | ||
| const observed: string[] = []; | ||
| const operation = operationStart.then(() => | ||
| freshLock.withSandboxLifecycleLock("alpha", () => { | ||
| observed.push( | ||
| freshAcquisition.isMcpLifecycleLockHeld( | ||
| "alpha", | ||
| freshPortableLock.portableLifecycleLockOptions(process.env).stateDir, | ||
| ) | ||
| ? "portable" | ||
| : "gateway", | ||
| ); | ||
| }), | ||
| ); | ||
| await transitionEntered; | ||
| startOperation(); | ||
| await new Promise<void>((resolve) => setImmediate(resolve)); | ||
| expect(observed).toEqual([]); | ||
|
|
||
| releaseTransition(); | ||
| await Promise.all([transition, operation]); | ||
| expect(observed).toEqual(["portable"]); | ||
| }); | ||
|
|
||
| it("classifies Portable-to-absent transitions after acquiring the host fence", async () => { | ||
| vi.restoreAllMocks(); | ||
| vi.resetModules(); | ||
| const [freshReceiptAuthority, freshPortableLock, freshAcquisition, freshHostFence, freshLock] = | ||
| await Promise.all([ | ||
| import("../../../onboard/experimental/hermes-portable-receipt"), | ||
| import("../../../onboard/experimental/portable-lifecycle-lock"), | ||
| import("../../../state/mcp-lifecycle-lock-acquisition"), | ||
| import("../../../state/portable-uninstall-retirement"), | ||
| import("./lock"), | ||
| ]); | ||
| let candidate = true; | ||
| vi.spyOn(freshReceiptAuthority, "hasHermesPortableReceiptCandidate").mockImplementation( | ||
| () => candidate, | ||
| ); | ||
| let releaseTransition!: () => void; | ||
| const transitionBlocked = new Promise<void>((resolve) => { | ||
| releaseTransition = resolve; | ||
| }); | ||
| let transitionStarted!: () => void; | ||
| const transitionEntered = new Promise<void>((resolve) => { | ||
| transitionStarted = resolve; | ||
| }); | ||
| const transition = freshHostFence.withCurrentPortableHostFence(async () => { | ||
| transitionStarted(); | ||
| await transitionBlocked; | ||
| candidate = false; | ||
| }); | ||
| const portableStateDir = freshPortableLock.portableLifecycleLockOptions(process.env).stateDir; | ||
| const gatewayStateDir = path.join(homeDir, ".nemoclaw", "gateways", "18080", "state"); | ||
| let startOperation!: () => void; | ||
| const operationStart = new Promise<void>((resolve) => { | ||
| startOperation = resolve; | ||
| }); | ||
| const observed: string[] = []; | ||
| const operation = operationStart.then(() => | ||
| freshLock.withSandboxLifecycleLock("alpha", () => { | ||
| observed.push( | ||
| freshAcquisition.isMcpLifecycleLockHeld("alpha", gatewayStateDir) && | ||
| !freshAcquisition.isMcpLifecycleLockHeld("alpha", portableStateDir) | ||
| ? "gateway" | ||
| : "portable", | ||
| ); | ||
| }), | ||
| ); | ||
| await transitionEntered; | ||
| startOperation(); | ||
| await new Promise<void>((resolve) => setImmediate(resolve)); | ||
| expect(observed).toEqual([]); | ||
|
|
||
| releaseTransition(); | ||
| await Promise.all([transition, operation]); | ||
| expect(observed).toEqual(["gateway"]); | ||
| }); | ||
|
|
||
| it("serializes competing Portable lifecycle operations on the same authority", async () => { | ||
| const events: string[] = []; | ||
| let releaseFirst!: () => void; | ||
| const firstWaiting = new Promise<void>((resolve) => { | ||
| releaseFirst = resolve; | ||
| }); | ||
| let firstEntered!: () => void; | ||
| const firstStarted = new Promise<void>((resolve) => { | ||
| firstEntered = resolve; | ||
| }); | ||
|
|
||
| const first = withSandboxLifecycleLock("alpha", async () => { | ||
| events.push("first-entered"); | ||
| firstEntered(); | ||
| await firstWaiting; | ||
| events.push("first-released"); | ||
| }); | ||
| await firstStarted; | ||
| const second = withSandboxLifecycleLock("alpha", () => { | ||
| events.push("second-entered"); | ||
| }); | ||
| await new Promise<void>((resolve) => setImmediate(resolve)); | ||
|
|
||
| expect(events).toEqual(["first-entered"]); | ||
| releaseFirst(); | ||
| await Promise.all([first, second]); | ||
| expect(events).toEqual(["first-entered", "first-released", "second-entered"]); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.