feat(config): export fixed managed vLLM serving profile - #11386
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit a6c2ab9 in the TypeScript / code-coverage/cliThe overall line coverage in commit a6c2ab9 in the Show a line coverage summary of the most impacted files.
Updated |
|
PR Review Advisor finished for commit |
Outcome
nemoclaw config exportcan represent the fixed managed Linux amd64 Lightning vLLM deployment, including its current catalog, model and image identity, required context window and observed host port. Unsupported recipes, missing ownership evidence and runtime drift still prevent export.Reason
Existing managed serving deployments cannot currently export their desired configuration. This slice adds one bounded recipe while preserving the private runtime credential boundary.
Related issues
Refs #10904. This PR stacks on
codex/config-export-bravefor its resolved provider-profile reader.Changes
Verification
npm run build:cli— passed.NODE_OPTIONS=--max-old-space-size=5120 npm run typecheck:cli— passed.NODE_OPTIONS=--max-old-space-size=5120 npm run validate:pr— passed in an isolated ARM container with canonical dependencies and validators, no contributor-host credentials, and networking disabled; source tree remained clean.Review notes
This draft depends on the Brave provider-profile reader. Its isolated feature diff is reviewed against that branch; merge the dependency first.
Sensitive paths are
src/lib/inference/config.tsand the changed files undersrc/lib/inference/serving/. The coordinator reviewed the rebased NVIDIA/NemoClaw candidate a6c2ab9 against the preserved implementation and peer-review evidence, including the private credential owner, bounded Docker observation, fixed catalog identity and refusal of stale or foreign resources. No remaining local finding is recorded. The Brave dependency also changes the sensitivetools/e2e/target-catalogue.mtsownership metadata; its local self-review at58afee35457257226879e3991a2d17eb97884c86found no remaining issue and is recorded in that PR. Independent PR review is still required; no approval or CI waiver is claimed.Real qualification on the exact Linux amd64 GPU profile remains required. Local Docker formatter tests use a disposable fake Docker API and do not prove model startup or successful routed inference. The reviewed GPU runner fixture is retained separately while the canonical assertion-growth guard rejects its budget increase.
Signed-off-by: Carlos Villela cvillela@nvidia.com