fix(deps): upgrade smol-toml to 1.8.0 - #11362
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughThe TOML parser dependency is updated from version 1.7.0 to 1.8.0. Regression tests run unfinished TOML arrays and inline tables in a bounded child process and verify syntax errors without event-loop blocking. ChangesTOML parser regression
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Merge Risk: ⚪ Minimal · up to The parser upgrade prevents malformed TOML arrays and inline tables ending in comments from hanging the CLI, returning syntax errors instead. The affected behavior is covered by bounded regression cases, with no remaining merge-blocking risk. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
🌿 Preview your docs: https://nvidia-preview-pr-11362.docs.buildwithfern.com/nemoclaw |
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 579c9e3 in the TypeScript / code-coverage/cliThe overall line coverage in commit 579c9e3 in the Updated |
|
PR Review Advisor finished for commit |
Outcome
Upgrade smol-toml to 1.8.0 so malformed TOML arrays and inline tables ending in a comment produce the existing generic configuration error instead of hanging the CLI.
Reason
The reviewed npm audit job blocks 1.7.0 for GHSA-7w5x-hrqm-74c2. Existing parser tests did not cover an unfinished structure with a comment at end of input.
Changes
Verification
npm run build:cli— passed in a container with Node 22.23.1 and npm 10.9.8.npx vitest run --project cli src/lib/sandbox/config-format.test.ts src/lib/inference/vllm-storage.test.ts src/lib/onboard/docker-driver-gateway-config-toml.test.ts src/lib/onboard/docker-driver-gateway-config-auth-contract.test.ts src/lib/state/state-file-key-merge-behavior.test.ts src/lib/state/state-file-key-merge-file-safety.test.ts src/lib/onboard/created-sandbox-finalization.test.ts— 123 tests passed across seven files with 1.8.0.npm --prefix nemoclaw run build— passed.npm run typecheck:cli,npx tsc -p jsconfig.json, and focused Oxlint — passed.npm audit --omit=dev --audit-level=high --registry=https://registry.npmjs.org/— zero vulnerabilities.NODE_OPTIONS=--max-old-space-size=5120 npm run validate:pr— passed all applicable pre-commit, commit-message, and pre-push checks in an isolated container; no tracked files changed.Review notes
Self-review covers NVIDIA/NemoClaw commit 579c9e3 and all three changed files, including the sensitive path src/lib/sandbox/config-format.test.ts. The regression exercises the production parser and bounds each child process to prevent a reintroduced hang from blocking the test worker. Validation used the unchanged checks from canonical main
270275f2a2b31a70fa72692d2ec304b5dffe8ee3in a container with no host credentials. No independent pre-publication review exists. This draft awaits independent review.Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit