fix(hermes): refresh image probe integrity pin - #11339
Closed
cjagwani wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Charan Jagwani <cjagwani@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Code Coverage OverviewLanguages: TypeScript TypeScript / code-coverage/pluginThe overall line coverage in commit 605ba00 in the TypeScript / code-coverage/cliThe overall line coverage in commit 605ba00 in the Show a line coverage summary of the most impacted files.
Updated |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Hermes sandbox images can verify and run the current reviewed image-build probe source. A focused regression test now rejects stale probe digests before image-build CI.
Reason
PR #11317 changed
agents/hermes/image-build-probes.pywithout updating its two Dockerfile digest bindings. Both Hermes image jobs on main run 34398766384 stopped at the fail-closed digest check.Related issues
Refs #10791
Changes
Verification
npx vitest run --project integration test/agents/hermes/hermes-image-build-probes.test.ts— 57 passed.npm run validate:pr— passed against main commitae5b2ca922023120f90e23242c133c774ae30aa0.605ba00d990c538a7c088deffc6a728da38ef4b3is Verified.Review notes
agents/hermes/Dockerfileis a contributor-sensitive path. A self-review of NVIDIA/NemoClaw commit605ba00d990c538a7c088deffc6a728da38ef4b3covered the complete Dockerfile and regression-test diff and found no additional change. A documentation writer review found no user-visible documentation impact. Independent maintainer review remains required.Signed-off-by: Charan Jagwani cjagwani@nvidia.com