ci: trust Node 24 Brev bootstrap template - #11329
Draft
cv wants to merge 1 commit into
Draft
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Allow the base-trusted installer checker to recognize the exact Node 24/npm 12 Brev bootstrap prepared in #11080. Existing trusted templates remain accepted; this PR does not change the bootstrap script or release pins.
Reason
The installer checker deliberately requires template approval on main before a later PR can change installer behavior. #11080 cannot authorize its own new template.
Changes
Add normalized Brev template SHA-256
ee86b418f29c48e4d4042cdb9bb5424eaaef0d89782134646c4b539e2849703eto the OpenShell 0.0.106 trust record. The proposed script installs checksum-verified Node.js 24.18.1 archives and integrity-verified npm 12.0.2, including cleanup if npm installation fails.Verification
npx vitest run --project integration test/install/installer-hash-check.test.ts— all 88 tests passed.npm run validate:pr— passed, including repository checks, commit-message validation, secret scanning, and the CLI type check.Review notes
GitHub CI completed for
99ec40d715a4af03db74502116289b907f21059c. The installer-hash check passed. Approval remains blocked by inherited failures: the Hermes image build has a stale probe checksum, and CLI shards 4, 6, and 11 report dashboard-forward, WeChat fixture, runtime-bundle checksum, and gateway-teardown mock failures. Those code and test files are unchanged from the recorded basebb5f1b009a6a12742ef0fadb8ec84315a4e36fec; the latter three test failures were also reproduced locally on that base. No CI waiver is claimed. CodeRabbit skipped the draft, so independent review is still pending.This changes a security-sensitive installer trust allowlist. Local self-review compared the full Brev script change with main and tested exact acceptance and tamper rejection. Independent maintainer review remains required before merge. The proposed template is from the locally repaired #11080 candidate
7e8d60a32b066fa6919e5fa02b7f86fb2abe43f3; that candidate has not been pushed yet. The complete proposed script diff is included below so this trust change can be reviewed before that candidate is published.Proposed Brev bootstrap diff against main
Signed-off-by: Carlos Villela cvillela@nvidia.com