ci(security): enable trusted npm audit reuse - #11035
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (7)
Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review. 📝 WalkthroughWalkthroughChangesThe CI installer and workflow dependency steps now disable npm audits and funding notices. Reviewed npm audit jobs now use a temporary cache directory. Contract tests verify these options and paths. CI npm controls
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to CI dependency installs no longer perform implicit npm audit or funding requests, while reviewed audit jobs use runner-temporary cache storage. The workflow and installer contracts are covered by updated tests, with no remaining merge-blocking risk identified. Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
|
PR Review Advisor finished for commit |
Outcome
Trusted pull request audit jobs now restore reviewed npm audit evidence without triggering redundant install-time advisory requests in CI paths that already have explicit reviewed audit coverage.
Reason
PR #11029 landed the cache-aware trusted action, so its PR callers can now pass cache-directory safely. Ordinary npm installs in the same reviewed CI paths should not make separate best-effort advisory calls.
Related issues
Refs #11028
Changes
Verification
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit