Skip to content

ci(security): authorize fast-uri lock transition - #10894

Merged
prekshivyas merged 1 commit into
mainfrom
fix/authorize-fast-uri-lock-transition
Sep 2, 2026
Merged

ci(security): authorize fast-uri lock transition#10894
prekshivyas merged 1 commit into
mainfrom
fix/authorize-fast-uri-lock-transition

Conversation

@jyaunches

@jyaunches jyaunches commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Outcome

Authorizes one bounded reviewed-lock transition from fast-uri 3.1.5 to 3.1.6 for the three dedicated production graphs.

Reason

PR #10892 updates vulnerable fast-uri locks, but the trusted base audit correctly rejects replacement lock hashes not pre-authorized by base-controlled configuration.

Changes

Verification

  • JSON validation passed.
  • Existing parser rejects malformed, equal, or non-SHA replacement hashes.

Prerequisite for PR #10892 and PR #10866.

Signed-off-by: Julie Yaunches jyaunches@nvidia.com

Summary by CodeRabbit

  • Chores
    • Updated locked runtime dependency metadata for OpenClaw, mcporter, and MCP tool discovery.
    • Existing lock integrity values remain unchanged.

Signed-off-by: Julie Yaunches <jyaunches@nvidia.com>
@github-code-quality

Copy link
Copy Markdown
Contributor

Code Coverage Overview

Languages: TypeScript

TypeScript / code-coverage/plugin

The overall line coverage in commit 3a92df1 in the fix/authorize-fast-u... branch remains at 96%, unchanged from commit 19bb986 in the main branch.

@coderabbitai

coderabbitai Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 44a0b4e4-8655-46a9-a9ab-d54eb55e1b64

📥 Commits

Reviewing files that changed from the base of the PR and between e01658e and 3a92df1.

📒 Files selected for processing (1)
  • ci/reviewed-npm-audit.json

Included review availability: Your plan provides up to 12 included reviews per hour; 10 remain after this review.


📝 Walkthrough

Walkthrough

The locked runtime graph entries for OpenClaw, mcporter, and MCP tool discovery now include replacementLockSha256 values while retaining their existing lockSha256 values.

Changes

Runtime graph hash updates

Layer / File(s) Summary
Record replacement lock hashes
ci/reviewed-npm-audit.json
OpenClaw, mcporter, and MCP tool discovery entries now include replacementLockSha256 values alongside their existing lock hashes.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3a92d

This change authorizes three bounded lock transitions in CI configuration, with replacement digests matching the intended lockfile updates. No actionable merge-blocking risk remains after normal checks and review.

Suggested reviewers: senthilr-nv, apurvvkumaria

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely identifies the main change: authorizing the fast-uri lock transition in CI security configuration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/authorize-fast-uri-lock-transition

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

PR Review Advisor finished for commit 3a92df1. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs

@jyaunches

Copy link
Copy Markdown
Contributor Author

This is the bounded base-authority prerequisite for security fix PR #10892 and receipt guard PR #10866. Current red image/audit checks are expected on this transition-only PR because it intentionally does not change vulnerable locks; all nine PR Review Advisor specialists found no issue. Please review/merge #10894 first, then #10892 can be refreshed against main and prove the authorized locks green.

@jyaunches

Copy link
Copy Markdown
Contributor Author

@ericksoa this is ready for independent review. All nine PR Review Advisor specialists are clear. The red audit/image checks are expected because this transition-only PR intentionally leaves current vulnerable locks unchanged while pre-authorizing the exact hashes consumed by stacked fix PR #10892. Please merge #10894 once satisfied; #10892 is already stacked on it and fresh security CI is running.

@prekshivyas
prekshivyas merged commit 80e15df into main Sep 2, 2026
88 of 95 checks passed
@prekshivyas
prekshivyas deleted the fix/authorize-fast-uri-lock-transition branch September 2, 2026 19:15
@wscurran wscurran added the chore Build, CI, dependency, or tooling maintenance label Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Build, CI, dependency, or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants