Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions src/lib/advisories/checks/host/toolchain.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -47,6 +47,27 @@ describe("host toolchain advisories (#3213)", () => {
]);
});

it("keeps the headless remote hint platform-neutral on macOS (#10734)", () => {
const result = runAdvisories(
TOOLCHAIN_HOST_ADVISORY_CHECKS,
{
...BASE_HOST,
platform: "darwin",
runtime: "docker-desktop",
isHeadlessLikely: true,
},
{ phase: "preflight.host" },
);

const hint = result.advisories.find(({ id }) => id === "headless_remote_hint");
expect(hint).toMatchObject({
reason: "Headless hosts often need explicit remote UI handling if you want browser access.",
commands: [
"Prefer SSH port forwarding for remote browser access. If the dashboard needs an external origin, set `CHAT_UI_URL` to its HTTPS URL before onboarding.",
],
});
});

it("preserves the WSL Docker short-circuit", () => {
const result = runAdvisories(
TOOLCHAIN_HOST_ADVISORY_CHECKS,
Expand Down
7 changes: 4 additions & 3 deletions src/lib/advisories/checks/host/toolchain.ts
Original file line number Diff line number Diff line change
Expand Up @@ -51,9 +51,10 @@ export const reviewHeadlessUiSettings: AdvisoryCheck<HostAssessment> = {
return hostAdvisory(reviewHeadlessUiSettings, {
title: "Review remote/headless UI settings",
kind: "info",
reason:
"Headless Linux hosts often need explicit remote UI handling if you want browser access.",
commands: ["Set `CHAT_UI_URL` when remote browser access matters."],
reason: "Headless hosts often need explicit remote UI handling if you want browser access.",
commands: [
"Prefer SSH port forwarding for remote browser access. If the dashboard needs an external origin, set `CHAT_UI_URL` to its HTTPS URL before onboarding.",
],
});
},
};
Expand Down
Loading