fix(advisor): validate hosted specialist artifacts - #10727
Closed
cv wants to merge 1 commit into
Closed
Conversation
Signed-off-by: Carlos Villela <cvillela@nvidia.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. 📝 WalkthroughWalkthroughThe PR review advisor now validates specialist artifact sets for local and hosted workflows. Hosted summary publication requires valid configuration and complete regular artifacts. Tests cover the expected session artifact and incomplete-artifact rejection. ChangesPR review advisor
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The PR adds fail-closed validation before hosted summaries are published and shares that validation with the local path. No actionable merge-blocking risk remains beyond normal checks and review. Sequence Diagram(s)sequenceDiagram
participant runAdvisorSpecialistCommand
participant validateSpecialistArtifacts
participant publishSpecialistJobSummary
runAdvisorSpecialistCommand->>validateSpecialistArtifacts: Validate generated artifacts
validateSpecialistArtifacts-->>runAdvisorSpecialistCommand: Return validation result
runAdvisorSpecialistCommand->>publishSpecialistJobSummary: Publish validated summary
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 2📝 Generate docstrings 💡
🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Comment |
Contributor
Collaborator
Author
|
Not likely to happen all that ofte |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Outcome
Hosted PR Advisor jobs now reject incomplete specialist artifacts before publishing their job summary.
Reason
The final review of #10701 found that a Markdown-only artifact could appear complete without its required native JSONL session trace.
Changes
Verification
npx vitest run --project integration test/automation/pull-requests/pr-review-advisor-openshell.test.ts test/automation/pull-requests/pr-review-advisor-local.test.ts test/automation/pull-requests/growth-guardrails.test.ts— 95 passed.npm run typecheck:cli— passed.npm run validate:pr— passed.DCO Sign-Off
Signed-off-by: Carlos Villela cvillela@nvidia.com
Summary by CodeRabbit
Bug Fixes
Tests