refactor(advisor): remove disconnected analyzer

.github/workflows/pr-review-advisor.yaml

@@ -34,12 +34,6 @@ on:
         required: false
         type: string
         default: main
-      run_analysis:
-        description: Run PR review advisor analysis
-        required: false
-        type: boolean
-        default: true
-
 # Each job declares its own privilege domain. In particular, no model-bearing
 # job can write to a pull request, and the publisher never receives the model
 # credential or the untrusted PR worktree.
@@ -105,7 +99,7 @@ jobs:
       # Pin runtime packages to reviewed versions. Updates go through normal
       # dependency review rather than floating in a secret-bearing job.
       PI_SDK_VERSION: "0.80.6"
-      # The review ledger imports TypeBox directly. Pi 0.80.6 shrinkwraps its
+      # The advisor tools import TypeBox directly. Pi 0.80.6 shrinkwraps its
       # own copy, so the advisor runtime must install this direct dependency.
       TYPEBOX_VERSION: "1.1.38"
       # Workflow-boundary modules parse YAML before the advisor session starts.
@@ -123,7 +117,6 @@ jobs:
       PR_REVIEW_ADVISOR_MODEL: ${{ matrix.advisor.model }}
       PR_REVIEW_ADVISOR_INTEREST: ${{ matrix.advisor.interest }}
       PR_REVIEW_ADVISOR_ARTIFACT_DIR: ${{ matrix.advisor.artifact_dir }}
-      PR_REVIEW_ADVISOR_RUN_ANALYSIS: ${{ github.event_name == 'workflow_dispatch' && inputs.run_analysis == false && '0' || '1' }}
       PR_REVIEW_ADVISOR_COMMENT_MARKER: "<!-- nemoclaw-pr-review-advisor -->"
       PR_REVIEW_ADVISOR_COMMENT_TITLE: PR Review Advisor
       PR_REVIEW_ADVISOR_COMMENT_LABEL: PR review advisor
@@ -264,7 +257,6 @@ jobs:
 
       # Shared lifecycle phases preserve the configure-only credential boundary.
       - name: Install OpenShell
-        if: ${{ env.PR_REVIEW_ADVISOR_RUN_ANALYSIS == '1' }}
         run: |
           env -u GITHUB_TOKEN -u GH_TOKEN -u PR_REVIEW_ADVISOR_API_KEY \
             NEMOCLAW_NON_INTERACTIVE=1 \
@@ -275,7 +267,6 @@ jobs:
         if: always()
         env:
           OPENAI_API_KEY: ${{ secrets.PR_REVIEW_ADVISOR_API_KEY }}
-          PR_REVIEW_ADVISOR_UNAVAILABLE_REASON: ${{ env.PR_REVIEW_ADVISOR_RUN_ANALYSIS == '0' && 'PR_REVIEW_ADVISOR_RUN_ANALYSIS=0' || 'OpenShell inference configuration failed or the advisor credential is unavailable' }}
         run: node --experimental-strip-types --no-warnings "$ADVISOR_DIR/tools/pr-review-advisor/specialist-lifecycle.mts" analysis
 
       - name: Upload specialist review

test/automation/pull-requests/code-change-considerations.test.ts

@@ -6,13 +6,10 @@ import { tmpdir } from "node:os";
 import path from "node:path";
 import { afterEach, describe, expect, it, vi } from "vitest";
 
-import { preparePromptArtifacts } from "../../../tools/pr-review-advisor/analyze.mts";
-import { artifactPaths } from "../../../tools/pr-review-advisor/artifacts.mts";
 import {
   buildSystemPrompt,
   readTrustedCodeChangeConsiderations,
 } from "../../../tools/pr-review-advisor/trusted-guidance.mts";
-import { metadata } from "../../helpers/pr-review-advisor-test-fixtures";
 
 const ROOT = path.resolve(import.meta.dirname, "../../..");
 const RESOURCE_PATH = path.join(
@@ -105,37 +102,4 @@ describe("shared code change considerations", () => {
     );
   });
 
-  it("writes visible failure artifacts for malformed Advisor input", () => {
-    const outDir = fs.mkdtempSync(path.join(tmpdir(), "advisor-considerations-failure-"));
-    const reviewMetadata = metadata();
-    mockTrustedConsiderationsRead(
-      () => "# Code Change Considerations\n\nThis lost its contract structure.",
-    );
-
-    try {
-      expect(() =>
-        preparePromptArtifacts({
-          artifacts: artifactPaths(outDir),
-          metadata: reviewMetadata,
-          diff: "",
-        }),
-      ).toThrow("Code change considerations malformed");
-      expect(
-        JSON.parse(fs.readFileSync(path.join(outDir, "pr-review-advisor-result.json"), "utf8")),
-      ).toMatchObject({
-        failed: true,
-        reason: expect.stringContaining("Code change considerations malformed"),
-      });
-      expect(
-        JSON.parse(
-          fs.readFileSync(path.join(outDir, "pr-review-advisor-final-result.json"), "utf8"),
-        ),
-      ).toMatchObject({
-        headSha: reviewMetadata.headSha,
-        reviewCompleteness: { requiresHumanReview: true },
-      });
-    } finally {
-      fs.rmSync(outDir, { recursive: true, force: true });
-    }
-  });
 });

test/automation/pull-requests/pr-review-advisor-context.test.ts

@@ -14,7 +14,7 @@ import {
   type OpenPrOverlap,
 } from "../../../tools/pr-review-advisor/github-context.mts";
 import { buildSystemPrompt } from "../../../tools/pr-review-advisor/trusted-guidance.mts";
-import { ROOT } from "../../helpers/pr-review-advisor-test-fixtures.ts";
+const ROOT = path.resolve(import.meta.dirname, "../../..");
 
 describe("PR review advisor", () => {
   afterEach(() => {

test/automation/pull-requests/pr-review-advisor-diff.test.ts

@@ -127,40 +127,6 @@ describe("PR review advisor diff", () => {
     }
   });
 
-  it("writes failure artifacts when trusted Git inputs are unavailable", () => {
-    const tmp = fs.mkdtempSync(path.join(tmpdir(), "nemoclaw-pr-advisor-diff-"));
-    const result = spawnSync(
-      process.execPath,
-      [
-        "--experimental-strip-types",
-        path.join(ROOT, "tools/pr-review-advisor/analyze.mts"),
-        "--base",
-        "missing-ref",
-        "--head",
-        "HEAD",
-        "--schema",
-        path.join(ROOT, "tools/pr-review-advisor/schema.json"),
-        "--out-dir",
-        tmp,
-      ],
-      { cwd: ROOT, encoding: "utf8" },
-    );
-
-    try {
-      expect(result.status).toBe(1);
-      expect(
-        JSON.parse(fs.readFileSync(path.join(tmp, "pr-review-advisor-result.json"), "utf8")),
-      ).toMatchObject({ failed: true });
-      expect(
-        JSON.parse(fs.readFileSync(path.join(tmp, "pr-review-advisor-final-result.json"), "utf8")),
-      ).toMatchObject({
-        headSha: expect.stringMatching(/^[0-9a-f]{40}$/u),
-        reviewCompleteness: { requiresHumanReview: true },
-      });
-    } finally {
-      fs.rmSync(tmp, { recursive: true, force: true });
-    }
-  });
 });
 
 function commit(cwd: string, message: string): void {