Skip to content

perf(cli): reuse current Hermes readiness authority #10607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
senthilr-nv merged 8 commits into from
Aug 30, 2026
Merged

perf(cli): reuse current Hermes readiness authority #10607

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fd5651c
perf(cli): reuse current Hermes readiness authority
senthilr-nv Aug 29, 2026
bfa4ca7
merge: refresh protected main for Hermes latency
senthilr-nv Aug 29, 2026
fe14a20
test(connect): require portable recovery authority
senthilr-nv Aug 29, 2026
1b98dc4
perf(hermes): reuse accepted portable readiness
senthilr-nv Aug 30, 2026
a3d657c
perf(hermes): classify portable latency
senthilr-nv Aug 30, 2026
1837a74
fix(hermes): retain command authority during probe recovery
senthilr-nv Aug 30, 2026
fda1b9d
merge: refresh protected main for Hermes latency
senthilr-nv Aug 30, 2026
553f16b
test(connect): prove portable route requalification
senthilr-nv Aug 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 3 additions & 75 deletions src/lib/actions/sandbox/connect-flow.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -635,13 +635,7 @@ describe("connectSandbox flow", () => {

await expect(harness.connectSandbox("alpha", { probeOnly: true })).resolves.toBeUndefined();

expect(harness.requalifyPortableAgentAuthoritySpy).toHaveBeenCalledWith(
"alpha",
expect.objectContaining({ readRegistry: expect.any(Function) }),
);
expect(harness.requalifyPortableAgentAuthoritySpy.mock.invocationCallOrder[0]!).toBeLessThan(
harness.inspectLaunchReadinessSpy.mock.invocationCallOrder[0]!,
);
expect(harness.requalifyPortableAgentAuthoritySpy).not.toHaveBeenCalled();
expect(harness.checkAndRecoverSpy).not.toHaveBeenCalled();
expect(harness.ensureLiveSandboxSpy).not.toHaveBeenCalled();
expect(harness.publishLaunchReadinessSpy).not.toHaveBeenCalled();
Expand Down Expand Up @@ -1037,7 +1031,7 @@ describe("connectSandbox flow", () => {
"process.exit(1)",
);
expect(harness.errorSpy.mock.calls.flat().join("\n")).toContain(
"receipt and registry authority disagree",
"missing, incomplete, or changed during launch-readiness verification",
);
expect(harness.recoverPortableDemoLifecycleSpy).not.toHaveBeenCalled();
expect(harness.captureResolvedOpenshellSpy).not.toHaveBeenCalled();
Expand Down Expand Up @@ -1128,72 +1122,6 @@ describe("connectSandbox flow", () => {
expect(harness.getSandboxDockerRuntimeSpy).not.toHaveBeenCalled();
});

it("requalifies accepted probe evidence against active schema-5 authority (#9203)", async () => {
const entry = {
name: "alpha",
agent: "hermes",
provider: "ollama-local",
model: "qwen3-vl:4b",
policies: [],
openshellDriver: "docker",
gatewayName: "nemoclaw",
lifecycleGeneration: "generation-1",
} as never;
const harness = createConnectHarness({
agentName: "hermes",
sessionAgent: { name: "hermes" },
registryEntry: entry,
portableReceiptDisposition: { kind: "hermes", phase: "active" },
portableRecoveryResult: { kind: "already-running" },
readinessDecision: {
kind: "accepted",
category: "accepted",
agent: { name: "hermes" },
sb: entry,
},
});

await expect(harness.connectSandbox("alpha", { probeOnly: true })).resolves.toBeUndefined();

expect(harness.recoverPortableDemoLifecycleSpy).toHaveBeenCalledOnce();
expect(harness.checkAndRecoverSpy).not.toHaveBeenCalled();
expect(harness.getSandboxDockerRuntimeSpy).not.toHaveBeenCalled();
expect(harness.dockerStartSpy).not.toHaveBeenCalled();
expect(harness.publishLaunchReadinessSpy).not.toHaveBeenCalled();
expect(harness.recoverHermesPortableOllamaInferenceSpy).toHaveBeenCalledOnce();
});

it("rejects accepted probe evidence when schema-5 authority disappears (#9203)", async () => {
const entry = {
name: "alpha",
agent: "hermes",
provider: null,
model: null,
policies: [],
openshellDriver: "docker",
gatewayName: "nemoclaw",
lifecycleGeneration: "generation-1",
} as never;
const harness = createConnectHarness({
agentName: "hermes",
registryEntry: entry,
portableReceiptDisposition: { kind: "hermes", phase: "active" },
portableRecoveryResult: { kind: "not-installed" },
readinessDecision: {
kind: "accepted",
category: "accepted",
agent: { name: "hermes" },
sb: entry,
},
});

await expect(harness.connectSandbox("alpha", { probeOnly: true })).rejects.toThrow(
"authority disappeared during probe",
);
expect(harness.checkAndRecoverSpy).not.toHaveBeenCalled();
expect(harness.runSandboxExecChildSpy).not.toHaveBeenCalled();
});

it("keeps active Hermes interactive setup inside receipt-owned recovery (#9203)", async () => {
vi.stubEnv("NVIDIA_INFERENCE_API_KEY", "do-not-forward");
vi.stubEnv("GITHUB_TOKEN", "do-not-forward");
Expand Down Expand Up @@ -1308,7 +1236,7 @@ describe("connectSandbox flow", () => {
"process.exit(1)",
);
expect(harness.errorSpy.mock.calls.flat().join("\n")).toContain(
"Hermes portable lifecycle authority is missing or incomplete",
"missing, incomplete, or changed during launch-readiness verification",
);
expect(harness.getSandboxDockerRuntimeSpy).not.toHaveBeenCalled();
expect(harness.dockerStartSpy).not.toHaveBeenCalled();
Expand Down
Loading
Loading