test(cli): guard OpenShell observation consumers

[rsliter]

Outcome

The repository now rejects any new or changed production OpenShell sandbox observation path unless it uses the typed adapter or has a checked-in follow-up disposition. The check classifies all 37 current direct sandbox list or sandbox get command sites and legacy raw-parser bindings without changing runtime behavior. Each current deferred disposition points to a follow-on capability issue assigned to rsliter.

Reason

PR #10132 established the typed sandbox observer, but PR #10537 later found another production liveness consumer that still built CLI arguments and interpreted raw output. Issue #9803 now permits partial delivery only when every deferred consumer is named and owned. A checked-in repository guard makes that rule executable and prevents another consumer from silently bypassing the adapter seam.

Related issues

Partial #9803

Depends on #10537

Relates to #9805, #9807, #9811, #9812, #9813, and #10514

Changes

• Add a TypeScript source audit for production sandbox list and sandbox get argument arrays, named legacy parser imports, namespace bindings, CommonJS bindings, and the remaining parser definitions.
• Record the exact command and parser-site count, disposition, tracking issue, and reason for every current source file.
• Fail when a source is unclassified, a classified count changes, a disposition becomes stale, or a source lacks a tracking issue or reason.
• Register the audit in npm run checks:repository and add negative tests for each failure mode.

The checked-in ledger names every deferred consumer:

• Phase 1 slice 2: Route policy and sandbox config through the OpenShell adapter #9805 and Make OpenShell the sole durable policy source of truth #10514: src/lib/shields/index.ts.
• Phase 1 slice 10: Route gateway targeting and lifecycle through the OpenShell adapter #9807: src/lib/actions/sandbox/destroy-gateway-cleanup.ts, src/lib/actions/sandbox/doctor.ts, src/lib/actions/sandbox/gateway-state.ts, src/lib/domain/sandbox/destroy.ts, src/lib/runtime-recovery.ts, and src/lib/state/gateway.ts.
• Phase 1 slice 3: Route sandbox create and delete through the OpenShell adapter #9811: src/lib/actions/sandbox/destroy-preflight.ts, rebuild-destroy-phase.ts, snapshot.ts, stop.ts, and vm-dns-monkeypatch.ts; src/lib/actions/uninstall/run-plan.ts; src/lib/onboard.ts; the Docker GPU patch, create, and reconnect helpers; Hermes portable lifecycle and onboarding; managed bootstrap; runtime-provider snapshots; sandbox create, GPU create, lifecycle, readiness tracing, recreate, and reuse helpers; and src/lib/runtime-recovery.ts.
• Phase 1 slice 9: Route logs, settings, diagnostics, and version checks through the OpenShell adapter #9812: src/commands/debug.ts, src/lib/diagnostics/debug.ts, and src/lib/onboard/docker-gpu-patch-diagnostics.ts. PR refactor(debug): use typed sandbox observer #10537 owns the debug liveness migration.
• Phase 1 slice 11: Complete the OpenShell CLI consumer sweep #9813: nemoclaw/src/blueprint/runner.ts.

The OpenShell client, gateway-drift, policy-authority, sandbox-identity, and sandbox-observer CLI files are classified as adapter-owned boundaries rather than deferred consumers.

Verification

• node_modules/.bin/tsx scripts/checks/openshell-sandbox-observation-boundary.mts completed with 37 verified dispositions.
• npx vitest run --project integration test/repository/openshell-sandbox-observation-boundary.test.ts test/repository/checks-runner.test.ts passed 2 files and 19 tests.
• npm run checks:repository passed with 1,847 files, 5,864 edges, 0 cycles, and exact membership for 2,625 test candidates.
• npm run build:cli and npm run typecheck:cli passed.
• Normal pre-commit and commit-message hooks passed for all commits.
• npm run check passed all relevant repository, formatting, lint, secret-scan, and architecture hooks, then stopped at existing all-files Hadolint warnings in unchanged Dockerfiles. This diff changes no Dockerfile.
• git diff --check passed.
• The diff contains no secrets, API keys, or credentials.

Documentation Writer Review

• Result: no-docs-needed
• Evidence: Reviewed exact commit dde48cc2a6e2b8d56b7d87aed62e13da83ea3976 against trusted base fa6b2c89eb01e2b27648cfea61208a9897d5fcb4, including the focused Advisor repair and all four changed paths. trackingIssues no longer claims the local ledger proves GitHub ownership, and the diagnostic now states both the assigned-owner requirement and the check's local limit. This changes repository enforcement only and does not change a public command, option, output, configuration, supported workflow, or security boundary. Independent validation passed the exact audit, 2 focused integration files and 19 tests, and git diff --check; supplied repository checks, CLI build, CLI typecheck, and normal hooks also passed.
• Agent: Codex Desktop

Review notes

This PR remains draft until #10537 merges. After that merge, the stale debug disposition must be removed and the exact audit, tests, and documentation review rerun on the updated base.

---

Signed-off-by: Rebecca Sliter 571084+rsliter@users.noreply.github.com

[copy-pr-bot]

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

_{Comment @coderabbitai help to get the list of available commands.}

[github-actions]

PR Review Advisor finished for commit dde48cc. Include the Advisor findings in the complete PR feedback collection. Verify and group valid findings before repair.

All previous runs