Set default Torch version if YY.MM format is not met #9776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]>
thomasdhc
force-pushed
the
donghyukc/optimizations_nv_version
branch
from
9841bbb to
1b9e9a2
Compare
Signed-off-by: Dong Hyuk Chang <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Dong Hyuk Chang <[email protected]>
Signed-off-by: Dong Hyuk Chang <[email protected]>
ericharper
reviewed
Jul 23, 2024
Comment on lines
+382
to
+383
| def is_official_release_version(nvidia_torch_version): | ||
| return re.fullmatch("[0-9][0-9]\.[0-9][0-9].*", nvidia_torch_version) # "YY.MM.*" |
There was a problem hiding this comment.
This is currently in the nemo 1.0 path, we'll need something similar for 2.0
There was a problem hiding this comment.
@thomasdhc Can we unblock this for 1.0 and file a JIRA for the 2.0 code path ?
|
@minitu could you review this PR? |
|
LGTM |
8 tasks
gautham-kollu
approved these changes
Jul 25, 2024
thomasdhc
added a commit
that referenced
this pull request
Jul 25, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]>
8 tasks
thomasdhc
added a commit
that referenced
this pull request
Jul 25, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Dong Hyuk Chang <[email protected]>
akoumpa
pushed a commit
that referenced
this pull request
Jul 25, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Alexandros Koumparoulis <[email protected]>
BoxiangW
pushed a commit
to BoxiangW/NeMo
that referenced
this pull request
Jul 30, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Boxiang Wang <[email protected]>
xuanzic
pushed a commit
to xuanzic/NeMo
that referenced
this pull request
Aug 1, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Vivian Chen <[email protected]>
ericharper
pushed a commit
that referenced
this pull request
Aug 1, 2024
* Update arch check for SD (#9783) * Update arch check for SD Signed-off-by: Jaemin Choi <[email protected]> * Apply isort and black reformatting Signed-off-by: minitu <[email protected]> --------- Signed-off-by: Jaemin Choi <[email protected]> Signed-off-by: minitu <[email protected]> Co-authored-by: Jaemin Choi <[email protected]> Co-authored-by: minitu <[email protected]> Signed-off-by: Dong Hyuk Chang <[email protected]> * Set default Torch version if YY.MM format is not met (#9776) * Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Jaemin Choi <[email protected]> Signed-off-by: minitu <[email protected]> Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Jaemin Choi <[email protected]> Co-authored-by: Jaemin Choi <[email protected]> Co-authored-by: minitu <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]>
monica-sekoyan
pushed a commit
that referenced
this pull request
Oct 14, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]>
hainan-xv
pushed a commit
to hainan-xv/NeMo
that referenced
this pull request
Nov 5, 2024
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]> Signed-off-by: Hainan Xu <[email protected]>
XuesongYang
pushed a commit
to paarthneekhara/NeMo
that referenced
this pull request
Jan 18, 2025
* Torch major and minor versions set to current year and month if YY.MM formatting is not met Signed-off-by: Dong Hyuk Chang <[email protected]> * Update nvidia torch version check Signed-off-by: Dong Hyuk Chang <[email protected]> * Remove redundant import Signed-off-by: Dong Hyuk Chang <[email protected]> * Formatting fix Signed-off-by: Dong Hyuk Chang <[email protected]> --------- Signed-off-by: Dong Hyuk Chang <[email protected]> Co-authored-by: Dong Hyuk Chang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Set default nvidia torch version
Collection: [nlp]
Changelog
Usage
# Add a code snippet demonstrating how to use thisGitHub Actions CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information