Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347) #9350

Merged
merged 5 commits into from
Jun 4, 2024

Conversation

titu1994
Copy link
Collaborator

  • Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on GPU. This matches the behavior of GreedyCTCInfer. Even though that behavior is unintentional, there is code depending on that behavior, including our jupyter notebooks.

Signed-off-by: Daniel Galvez [email protected]

  • Apply isort and black reformatting

Signed-off-by: titu1994 [email protected]


Signed-off-by: Daniel Galvez [email protected]
Signed-off-by: titu1994 [email protected]
Co-authored-by: Somshubra Majumdar [email protected]
Co-authored-by: titu1994 [email protected]
Co-authored-by: Nithin Rao [email protected]
(cherry picked from commit aed9d07)

What does this PR do ?

Information is here - #9347

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.

Signed-off-by: Daniel Galvez <[email protected]>

* Apply isort and black reformatting

Signed-off-by: titu1994 <[email protected]>

---------

Signed-off-by: Daniel Galvez <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: titu1994 <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
(cherry picked from commit aed9d07)
@titu1994 titu1994 requested a review from nithinraok May 30, 2024 17:21
@titu1994 titu1994 added Run CICD and removed Run CICD labels Jun 1, 2024
@ericharper ericharper merged commit 60525c8 into r2.0.0rc0 Jun 4, 2024
111 checks passed
@ericharper ericharper deleted the cherrypick_greedyctc branch June 4, 2024 05:43
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.

Signed-off-by: Daniel Galvez <[email protected]>

* Apply isort and black reformatting

Signed-off-by: titu1994 <[email protected]>

---------

Signed-off-by: Daniel Galvez <[email protected]>
Signed-off-by: titu1994 <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: titu1994 <[email protected]>
Co-authored-by: Nithin Rao <[email protected]>
(cherry picked from commit aed9d07)

* Add Packaging to install documentation

Signed-off-by: smajumdar <[email protected]>

* Mark confidence tests as please fix me

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Daniel Galvez <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
titu1994 added a commit that referenced this pull request Jun 4, 2024
) (#9371)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.



* Apply isort and black reformatting



---------






(cherry picked from commit aed9d07)

* Add Packaging to install documentation



* Mark confidence tests as please fix me



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Daniel Galvez <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
BoxiangW pushed a commit to BoxiangW/NeMo that referenced this pull request Jun 5, 2024
… (NVIDIA#9350) (NVIDIA#9371)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (NVIDIA#9347)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.

* Apply isort and black reformatting

---------

(cherry picked from commit aed9d07)

* Add Packaging to install documentation

* Mark confidence tests as please fix me

---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Daniel Galvez <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
Signed-off-by: Boxiang Wang <[email protected]>
janekl pushed a commit that referenced this pull request Jun 12, 2024
) (#9371)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (#9347)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.



* Apply isort and black reformatting



---------






(cherry picked from commit aed9d07)

* Add Packaging to install documentation



* Mark confidence tests as please fix me



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Daniel Galvez <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
Signed-off-by: Jan Lasek <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
… (NVIDIA#9350) (NVIDIA#9371)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer. (NVIDIA#9347)

* Fix GreedyBatchedCTCInfer regression from GreedyCTCInfer.

decoder_lengths is allowed to be on CPU even when decoder_output is on
GPU. This matches the behavior of GreedyCTCInfer. Even though that
behavior is unintentional, there is code depending on that behavior,
including our jupyter notebooks.



* Apply isort and black reformatting



---------






(cherry picked from commit db26475)

* Add Packaging to install documentation



* Mark confidence tests as please fix me



---------

Signed-off-by: smajumdar <[email protected]>
Co-authored-by: Somshubra Majumdar <[email protected]>
Co-authored-by: Daniel Galvez <[email protected]>
Co-authored-by: Pablo Garay <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants