Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move pooler under post_process #9328

Merged
merged 4 commits into from
May 29, 2024
Merged

Conversation

dimapihtar
Copy link
Collaborator

What does this PR do ?

Moves pooler layer to post_process in order to avoid saving checkpoint error.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

GitHub Actions CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

The GitHub Actions CI will run automatically when the "Run CICD" label is added to the PR.
To re-run CI remove and add the label again.
To run CI on an untrusted fork, a NeMo user with write access must first click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Dmytro Pykhtar <[email protected]>
@github-actions github-actions bot added the NLP label May 28, 2024
Dmytro Pykhtar added 2 commits May 28, 2024 06:30
Signed-off-by: Dmytro Pykhtar <[email protected]>
@shanmugamr1992 shanmugamr1992 merged commit 86a0bb6 into r2.0.0rc0 May 29, 2024
112 checks passed
@shanmugamr1992 shanmugamr1992 deleted the dpykhtar/bert_pooler_fix branch May 29, 2024 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants