Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NeMo-UX] Add mixed-precision plugin #9065

Merged
merged 11 commits into from
May 2, 2024
Merged

[NeMo-UX] Add mixed-precision plugin #9065

merged 11 commits into from
May 2, 2024

Conversation

marcromeyn
Copy link
Collaborator

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.

There's no need to comment jenkins on the PR to trigger Jenkins CI.
The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

Signed-off-by: Chen Cui <[email protected]>
assert megatron_parallel.forward_step == mock_forward_step
assert megatron_parallel.loss_reduction == mock_loss_reduction

def test_init_with_virtual_pipeline(self, mocker, mock_pipeline):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this test is getting called and failing during the CPU unit tests

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added cpu=True to fix this

@cuichenx cuichenx added Run CICD and removed Run CICD labels May 1, 2024
@cuichenx cuichenx mentioned this pull request May 2, 2024
8 tasks
@cuichenx cuichenx merged commit 0643511 into main May 2, 2024
134 checks passed
@cuichenx cuichenx deleted the nemo-ux/mixed-precision branch May 2, 2024 03:47
suiyoubi pushed a commit that referenced this pull request May 2, 2024
* Adding MegatronParallel

* Move over _strategy_liMegatronCheckpointIO

* Adding GPTModel & MockDataModule

* Adding mixed-precision to NeMo

* Fix import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* revert unintended changes

Signed-off-by: Chen Cui <[email protected]>

* clean up code and reinstate mix precision tests

Signed-off-by: Chen Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean up

Signed-off-by: Chen Cui <[email protected]>

* use cpu for unit test

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chen Cui <[email protected]>
Signed-off-by: Ao Tang <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Adding MegatronParallel

* Move over _strategy_liMegatronCheckpointIO

* Adding GPTModel & MockDataModule

* Adding mixed-precision to NeMo

* Fix import

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* revert unintended changes

Signed-off-by: Chen Cui <[email protected]>

* clean up code and reinstate mix precision tests

Signed-off-by: Chen Cui <[email protected]>

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* clean up

Signed-off-by: Chen Cui <[email protected]>

* use cpu for unit test

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Chen Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants