docs and simplification of cmd args #8979
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: arendu <[email protected]>
|
jenkins |
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| num_doc_samples_per_dataset = [[None]] * len(data_cfg.doc_file_names) | ||
| num_query_files = len(data_cfg.query_file_names) if data_cfg.query_file_names is not None else 0 | ||
| num_doc_files = len(data_cfg.doc_file_names) if data_cfg.doc_file_names is not None else 0 | ||
| num_query_samples_per_dataset = [[None]] * num_query_files |
Check notice
Code scanning / CodeQL
Unused local variable Note
| num_query_files = len(data_cfg.query_file_names) if data_cfg.query_file_names is not None else 0 | ||
| num_doc_files = len(data_cfg.doc_file_names) if data_cfg.doc_file_names is not None else 0 | ||
| num_query_samples_per_dataset = [[None]] * num_query_files | ||
| num_doc_samples_per_dataset = [[None]] * num_doc_files |
Check notice
Code scanning / CodeQL
Unused local variable Note
Signed-off-by: arendu <[email protected]>
Signed-off-by: arendu <[email protected]>
JRD971000
reviewed
Apr 22, 2024
|
|
||
| python3 /NeMo/examples/nlp/information_retrieval/megatron_gpt_embedding_finetuning.py \ | ||
| exp_manager.exp_dir="PATH_TO_SAVE_LORA_WEIGHTS" \ | ||
| model.global_batch_size=4 \ # exact choice for global batch size is data dependent typical values are in the rage of 32 to 128. |
|
Great doc @arendu , just a few typos to fix. Btw, I saw no Jenkins test, is cicd-main.yml the replacement? |
Signed-off-by: Adi Renduchintala <[email protected]>
JRD971000
previously approved these changes
Apr 22, 2024
Signed-off-by: arendu <[email protected]>
…DIA/NeMo into adithyare/docs_gpt_embedding
JRD971000
previously approved these changes
Apr 23, 2024
Signed-off-by: arendu <[email protected]>
Signed-off-by: Adi Renduchintala <[email protected]>
JRD971000
approved these changes
Apr 29, 2024
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
* docs and simplification of cmd args Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added cicd test Signed-off-by: arendu <[email protected]> * added cicd test is needs Signed-off-by: arendu <[email protected]> * Update information_retrieval.rst Signed-off-by: Adi Renduchintala <[email protected]> * updated to fix wrong file paths Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * Update cicd-main.yml Signed-off-by: Adi Renduchintala <[email protected]> --------- Signed-off-by: arendu <[email protected]> Signed-off-by: Adi Renduchintala <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pablo Garay <[email protected]> Signed-off-by: Ao Tang <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* docs and simplification of cmd args Signed-off-by: arendu <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * added cicd test Signed-off-by: arendu <[email protected]> * added cicd test is needs Signed-off-by: arendu <[email protected]> * Update information_retrieval.rst Signed-off-by: Adi Renduchintala <[email protected]> * updated to fix wrong file paths Signed-off-by: arendu <[email protected]> * update Signed-off-by: arendu <[email protected]> * Update cicd-main.yml Signed-off-by: Adi Renduchintala <[email protected]> --------- Signed-off-by: arendu <[email protected]> Signed-off-by: Adi Renduchintala <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Pablo Garay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
The Jenkins CI system has been replaced by GitHub Actions self-hosted runners.
There's no need to comment
jenkinson the PR to trigger Jenkins CI.The GitHub Actions CI will run automatically when the PR is opened.
To run CI on an untrusted fork, a NeMo user with write access must click "Approve and run".
Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information