Fix union type annotations for autodoc+mock-import rendering #8956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Piotr Żelasko <[email protected]>
|
jenkins |
erastorgueva-nv
approved these changes
Apr 17, 2024
xingyaoww
pushed a commit
to xingyaoww/NeMo
that referenced
this pull request
Apr 23, 2024
…8956) Signed-off-by: Piotr Żelasko <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Elena Rastorgueva <[email protected]>
alxzhang-amazon
pushed a commit
to alxzhang-amazon/NeMo
that referenced
this pull request
Apr 26, 2024
…8956) Signed-off-by: Piotr Żelasko <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Elena Rastorgueva <[email protected]>
galv
pushed a commit
to galv/NeMo
that referenced
this pull request
Apr 29, 2024
…8956) Signed-off-by: Piotr Żelasko <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Elena Rastorgueva <[email protected]>
suiyoubi
pushed a commit
that referenced
this pull request
May 2, 2024
Signed-off-by: Piotr Żelasko <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Elena Rastorgueva <[email protected]> Signed-off-by: Ao Tang <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
…8956) Signed-off-by: Piotr Żelasko <[email protected]> Co-authored-by: Pablo Garay <[email protected]> Co-authored-by: Elena Rastorgueva <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Sphinx's autodoc with mocked imports cannot handle
a | btyping syntax when one of the arguments is a forward reference (used by autodoc to substitute imported classes). Introducing forward references also brakes the type dispatch mechanism in@singledispatch. I used the opportunity to fix a few other obvious errors that I saw in the long list of sphinx warnings.Collection: ASR
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information