Added support for neptune logger #8210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Harishankar G <[email protected]>
8 tasks
for more information, see https://pre-commit.ci
| @@ -195,6 +195,36 @@ def test_trainer_loggers(self, tmp_path): | |||
| ) | |||
| assert isinstance(test_trainer.logger, pl.loggers.WandbLogger) | |||
|
|
|||
| @pytest.mark.unit | |||
| def test_trainer_neptune_logger(self, tmp_path): | |||
| pytest.importorskip("neptune", reason="could not import `neptune`, use `pip install neptune` to run this test") | |||
There was a problem hiding this comment.
Added conditional test case skip if neptune is not installed.
| if "api_key" not in neptune_kwargs and not os.getenv("NEPTUNE_API_TOKEN", None): | ||
| raise ValueError( | ||
| "either api_key should be set in neptune_kwargs or NEPTUNE_API_TOKEN should be set in environment variable for neptune_logger" | ||
| ) |
There was a problem hiding this comment.
Havent checked for import error here, as PyTorchLightning by default checks for the same within its NeptuneLogger wrapper.
Signed-off-by: Harishankar G <[email protected]>
… into nemo_main Signed-off-by: Harishankar G <[email protected]>
|
jenkins |
|
Hi @titu1994 what would be the next process to get this merged to the main trunk ? |
|
Could you avoid merging the main branch with this PR, I need to see the tests pass. It is fine if the branch is out of date with the main branch. |
|
jenkins |
I guess the automation is completed and all checks have passed. |
yaoyu-33
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Added support for neptune logger Signed-off-by: Harishankar G <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed config indentation in example config Signed-off-by: Harishankar G <[email protected]> --------- Signed-off-by: Harishankar G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
stevehuang52
pushed a commit
that referenced
this pull request
Jan 31, 2024
* Added support for neptune logger Signed-off-by: Harishankar G <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed config indentation in example config Signed-off-by: Harishankar G <[email protected]> --------- Signed-off-by: Harishankar G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: stevehuang52 <[email protected]>
ssh-meister
pushed a commit
to ssh-meister/NeMo
that referenced
this pull request
Feb 15, 2024
* Added support for neptune logger Signed-off-by: Harishankar G <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed config indentation in example config Signed-off-by: Harishankar G <[email protected]> --------- Signed-off-by: Harishankar G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Sasha Meister <[email protected]>
pablo-garay
pushed a commit
that referenced
this pull request
Mar 19, 2024
* Added support for neptune logger Signed-off-by: Harishankar G <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed config indentation in example config Signed-off-by: Harishankar G <[email protected]> --------- Signed-off-by: Harishankar G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Pablo Garay <[email protected]>
rohitrango
pushed a commit
to rohitrango/NeMo
that referenced
this pull request
Jun 25, 2024
* Added support for neptune logger Signed-off-by: Harishankar G <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Fixed config indentation in example config Signed-off-by: Harishankar G <[email protected]> --------- Signed-off-by: Harishankar G <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Adds Neptune logging support to NeMo which is already exposed by the PTL trainer.
Collection: Core, NLP
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
@titu1994
Additional Information