Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the tp overlap switch #8195

Merged
merged 2 commits into from
Jan 23, 2024
Merged

Fixed the tp overlap switch #8195

merged 2 commits into from
Jan 23, 2024

Conversation

sanandaraj5597
Copy link
Collaborator

What does this PR do ?

Added a switch to pass tp_overlap to MCORE transformer config.

Signed-off-by: Selvaraj Anandaraj <[email protected]>
@github-actions github-actions bot added the NLP label Jan 18, 2024
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper
Copy link
Collaborator

jenkins

@erhoo82
Copy link
Collaborator

erhoo82 commented Jan 23, 2024

jenkins

@ericharper ericharper merged commit c09b114 into main Jan 23, 2024
15 checks passed
@ericharper ericharper deleted the tp_overlap_switch branch January 23, 2024 22:08
minitu pushed a commit to minitu/NeMo that referenced this pull request Jan 30, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
yaoyu-33 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
vasunvidia pushed a commit to vasunvidia/NeMo that referenced this pull request Feb 1, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
jbaczek pushed a commit to jbaczek/NeMo that referenced this pull request Feb 2, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Signed-off-by: Jan Baczek <[email protected]>
jbaczek pushed a commit to jbaczek/NeMo that referenced this pull request Feb 2, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Signed-off-by: Jan Baczek <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
minitu pushed a commit to minitu/NeMo that referenced this pull request Mar 7, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Layali R <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants