Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add random_seed argument to generate #8162

Merged
merged 1 commit into from
Jan 22, 2024

Conversation

Kipok
Copy link
Collaborator

@Kipok Kipok commented Jan 12, 2024

What does this PR do ?

Add random_seed argument to generate. By default it does not set anything, so backward compatibility is preserved.

Collection: NLP

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@Kipok Kipok requested a review from ericharper January 12, 2024 17:54
@github-actions github-actions bot added the NLP label Jan 12, 2024
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper
Copy link
Collaborator

jenkins

2 similar comments
@ericharper
Copy link
Collaborator

jenkins

@Kipok
Copy link
Collaborator Author

Kipok commented Jan 19, 2024

jenkins

@Kipok Kipok merged commit b84c231 into NVIDIA:main Jan 22, 2024
11 checks passed
PannuMuthu pushed a commit to PannuMuthu/NeMo that referenced this pull request Jan 26, 2024
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Pratyush Muthukumar <[email protected]>
PannuMuthu pushed a commit to PannuMuthu/NeMo that referenced this pull request Jan 29, 2024
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Pratyush Muthukumar <[email protected]>
PannuMuthu pushed a commit to PannuMuthu/NeMo that referenced this pull request Jan 29, 2024
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
Signed-off-by: Igor Gitman <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants