Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #8156

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Update dependencies #8156

merged 3 commits into from
Jan 12, 2024

Conversation

titu1994
Copy link
Collaborator

@titu1994 titu1994 commented Jan 11, 2024

What does this PR do ?

Updates dependencies for NeMo
Fixes #8118

Collection: [Core, Common]

Changelog

  • Remove Numpy upperbound
  • Remove pydantic pin < 2

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

@github-actions github-actions bot added the NLP label Jan 12, 2024
@github-actions github-actions bot added the ASR label Jan 12, 2024
@titu1994
Copy link
Collaborator Author

jenkins

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@titu1994 titu1994 merged commit 62b27b7 into main Jan 12, 2024
15 checks passed
@titu1994 titu1994 deleted the fix_dependencies branch January 12, 2024 21:40
minitu pushed a commit to minitu/NeMo that referenced this pull request Jan 19, 2024
* Update dependencies

Signed-off-by: smajumdar <[email protected]>

* Update numpy.long to numpy.longlong (long deprecated in np 24)

Signed-off-by: smajumdar <[email protected]>

* Update all deprecatd numpy types

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* Update dependencies

Signed-off-by: smajumdar <[email protected]>

* Update numpy.long to numpy.longlong (long deprecated in np 24)

Signed-off-by: smajumdar <[email protected]>

* Update all deprecatd numpy types

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
* Update dependencies

Signed-off-by: smajumdar <[email protected]>

* Update numpy.long to numpy.longlong (long deprecated in np 24)

Signed-off-by: smajumdar <[email protected]>

* Update all deprecatd numpy types

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Update dependencies

Signed-off-by: smajumdar <[email protected]>

* Update numpy.long to numpy.longlong (long deprecated in np 24)

Signed-off-by: smajumdar <[email protected]>

* Update all deprecatd numpy types

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove Pydantic Version Constraint Due to Inflect Update
2 participants