Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added sample cpu_offloading switch to YAML #8148

Merged
merged 5 commits into from
Jan 24, 2024
Merged

Added sample cpu_offloading switch to YAML #8148

merged 5 commits into from
Jan 24, 2024

Conversation

sanandaraj5597
Copy link
Collaborator

What does this PR do ?

Add a sample to enable cpu offloading in megatron_gpt_config.yaml

@github-actions github-actions bot added the NLP label Jan 10, 2024
Signed-off-by: Selvaraj Anandaraj <[email protected]>
ericharper
ericharper previously approved these changes Jan 23, 2024
Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper
Copy link
Collaborator

Jenkins

@erhoo82 erhoo82 self-requested a review January 23, 2024 16:26
Signed-off-by: Selvaraj Anandaraj <[email protected]>
@ericharper
Copy link
Collaborator

jenkins

1 similar comment
@ericharper
Copy link
Collaborator

jenkins

@ericharper
Copy link
Collaborator

jenkins

1 similar comment
@ericharper
Copy link
Collaborator

jenkins

Copy link
Collaborator

@ericharper ericharper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@ericharper ericharper merged commit 0773702 into main Jan 24, 2024
15 checks passed
@ericharper ericharper deleted the cpu_offload branch January 24, 2024 17:53
yaoyu-33 pushed a commit that referenced this pull request Jan 31, 2024
* Added sample cpu_offloading switch to YAML

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Added comments

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Removed arithmetic op

Signed-off-by: Selvaraj Anandaraj <[email protected]>

---------

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
stevehuang52 pushed a commit that referenced this pull request Jan 31, 2024
* Added sample cpu_offloading switch to YAML

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Added comments

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Removed arithmetic op

Signed-off-by: Selvaraj Anandaraj <[email protected]>

---------

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: stevehuang52 <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* Added sample cpu_offloading switch to YAML

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Added comments

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Removed arithmetic op

Signed-off-by: Selvaraj Anandaraj <[email protected]>

---------

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
pablo-garay pushed a commit that referenced this pull request Mar 19, 2024
* Added sample cpu_offloading switch to YAML

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Added comments

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Removed arithmetic op

Signed-off-by: Selvaraj Anandaraj <[email protected]>

---------

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Signed-off-by: Pablo Garay <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Added sample cpu_offloading switch to YAML

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Added comments

Signed-off-by: Selvaraj Anandaraj <[email protected]>

* Removed arithmetic op

Signed-off-by: Selvaraj Anandaraj <[email protected]>

---------

Signed-off-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Selvaraj Anandaraj <[email protected]>
Co-authored-by: Eric Harper <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants