Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: numba.*_num_threads resets torch num_threads #8141 #8145

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

itzsimpl
Copy link
Contributor

@itzsimpl itzsimpl commented Jan 9, 2024

What does this PR do ?

Temporary fix until numba/numba#9387 gets resolved.

Collection: [ASR]

Changelog

  • wrap rnnt numba num_threads check and change to protect torch num_threads from being reset.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the ASR label Jan 9, 2024
@titu1994
Copy link
Collaborator

titu1994 commented Jan 9, 2024

Could you sign the commits in PR by following the DCOBot?

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix !

temporary fix until numba/numba#9387 gets resolved.

Signed-off-by: Iztok Lebar Bajec <[email protected]>
@titu1994
Copy link
Collaborator

jenkins

@titu1994 titu1994 self-assigned this Jan 10, 2024
@titu1994
Copy link
Collaborator

jenkins

@titu1994
Copy link
Collaborator

Hmm core dumped in numba unit-tests. I think ill try running them one more time in case it was a fluke, and then well need to debug more

@titu1994 titu1994 merged commit 03e7cf1 into NVIDIA:main Jan 11, 2024
11 checks passed
@itzsimpl itzsimpl deleted the patch-2 branch January 12, 2024 15:22
minitu pushed a commit to minitu/NeMo that referenced this pull request Jan 19, 2024
…#8145)

temporary fix until numba/numba#9387 gets resolved.

Signed-off-by: Iztok Lebar Bajec <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
…#8145)

temporary fix until numba/numba#9387 gets resolved.

Signed-off-by: Iztok Lebar Bajec <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
…#8145)

temporary fix until numba/numba#9387 gets resolved.

Signed-off-by: Iztok Lebar Bajec <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants