Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PEFT UX #8131

Merged
merged 2 commits into from
Jan 8, 2024
Merged

Improve PEFT UX #8131

merged 2 commits into from
Jan 8, 2024

Conversation

cuichenx
Copy link
Collaborator

@cuichenx cuichenx commented Jan 5, 2024

What does this PR do ?

Two improvements of PEFT UX

  1. Correct layer_selection logging messages in the case of more than one adapters.
  2. Make output (label, ground truth) field optional for test data, for use cases where user only wants to generate text with gpt_peft_eval and not calculate any metrics.
    • Note that using the default config file, data.test_ds.label_key and data.test_ds.prompt_template still reference an "output" field. These do not need to be changed. This PR simply ignores a key error if data.test_ds.label_key does not exist in the test data file.

Collection: NLP

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation
  • User Experience Improvement

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@github-actions github-actions bot added the NLP label Jan 5, 2024
@cuichenx
Copy link
Collaborator Author

cuichenx commented Jan 5, 2024

jenkins

@cuichenx cuichenx requested a review from arendu January 8, 2024 17:25
Copy link
Collaborator

@arendu arendu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arendu arendu merged commit c6c2643 into main Jan 8, 2024
15 checks passed
@arendu arendu deleted the chcui/improve_peft_ux branch January 8, 2024 20:04
minitu pushed a commit to minitu/NeMo that referenced this pull request Jan 19, 2024
* fix layer selection logging in the case of more than one adapters

Signed-off-by: Chen Cui <[email protected]>

* make output (ground truth) field optional for test data

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* fix layer selection logging in the case of more than one adapters

Signed-off-by: Chen Cui <[email protected]>

* make output (ground truth) field optional for test data

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* fix layer selection logging in the case of more than one adapters

Signed-off-by: Chen Cui <[email protected]>

* make output (ground truth) field optional for test data

Signed-off-by: Chen Cui <[email protected]>

---------

Signed-off-by: Chen Cui <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants