Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add text metrics to asr eval #8087

Merged
merged 5 commits into from
Dec 29, 2023
Merged

Add text metrics to asr eval #8087

merged 5 commits into from
Dec 29, 2023

Conversation

stevehuang52
Copy link
Collaborator

What does this PR do ?

Add some text metrics to ASR evaluator to support AST models

Signed-off-by: stevehuang52 <[email protected]>
@github-actions github-actions bot added the ASR label Dec 27, 2023
Comment on lines +282 to +285
# if return_hypotheses:
# # dump log probs per file
# for idx in range(logits.shape[0]):
# current_hypotheses[idx].y_sequence = logits[idx][: logits_len[idx]]

Check notice

Code scanning / CodeQL

Commented-out code Note

This comment appears to contain commented-out code.
@stevehuang52
Copy link
Collaborator Author

jenkins

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nltk has issues on clusters, I'll send you a thread on slack later. Make the class with imports nltk run only inside of the place that's needed, not at the top of the file.

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind above comment, nltk itself is fine, it was another library that was acting poorly by installing nltk stuff at import time.
Lgtm

@titu1994
Copy link
Collaborator

jenkins

@stevehuang52 stevehuang52 merged commit 13c4d5e into main Dec 29, 2023
15 checks passed
@stevehuang52 stevehuang52 deleted the add_text_metrics_evaluator branch December 29, 2023 15:34
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* add text metrics to asr eval

Signed-off-by: stevehuang52 <[email protected]>

* temporary fix for EncDecTransfModelBPE

Signed-off-by: stevehuang52 <[email protected]>

---------

Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* add text metrics to asr eval

Signed-off-by: stevehuang52 <[email protected]>

* temporary fix for EncDecTransfModelBPE

Signed-off-by: stevehuang52 <[email protected]>

---------

Signed-off-by: stevehuang52 <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* add text metrics to asr eval

Signed-off-by: stevehuang52 <[email protected]>

* temporary fix for EncDecTransfModelBPE

Signed-off-by: stevehuang52 <[email protected]>

---------

Signed-off-by: stevehuang52 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants