Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

run with non-dev option #8077

Merged
merged 1 commit into from
Dec 22, 2023
Merged

run with non-dev option #8077

merged 1 commit into from
Dec 22, 2023

Conversation

nithinraok
Copy link
Collaborator

What does this PR do ?

Looks like pip installs run with -e option, don;t load well without restarting.

Collection: [TUTORIALS]

Changelog

  • Run without pip editable

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

run with non-dev option
41953b5 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
@github-actions github-actions bot added the ASR label Dec 22, 2023
@titu1994 titu1994 merged commit 6e1bb79 into r1.22.0 Dec 22, 2023
12 checks passed
@titu1994 titu1994 deleted the fix_notebook branch December 22, 2023 10:26
github-actions bot pushed a commit that referenced this pull request Dec 22, 2023
@nithinraok @web-flow
run with non-dev option (#8077)
f894c80 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao Koluguri <nithinraok>
nithinraok added a commit that referenced this pull request Dec 23, 2023
@github-actions @nithinraok
run with non-dev option (#8077) (#8078)
274a21b 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
@github-actions @nithinraok @pzelasko
run with non-dev option (NVIDIA#8077) (NVIDIA#8078)
f9bbc0a 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
@github-actions @nithinraok @sashameister
run with non-dev option (NVIDIA#8077) (NVIDIA#8078)
b7b3552 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
@github-actions @nithinraok
run with non-dev option (NVIDIA#8077) (NVIDIA#8078)
c2da018 
Signed-off-by: Nithin Rao Koluguri <nithinraok>
Co-authored-by: Nithin Rao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titu1994 titu1994 titu1994 approved these changes

Assignees
No one assigned
Labels
ASR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nithinraok @titu1994