Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Increase length check tolerance to prevent test failing #8067

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

anteju
Copy link
Collaborator

@anteju anteju commented Dec 20, 2023

What does this PR do ?

This PR relaxes constrain on the length to prevent intermittent test failures.

Collection: ASR tests

Changelog

  • Increased threshold for 1 to 2

Original test failure

  • You can potentially add a usage example below
=========================== short test summary info ============================

FAILED tests/collections/asr/decoding/test_rnnt_decoding.py::TestRNNTDecoding::test_beam_decoding_preserve_alignments[beam_config4] - AssertionError: assert tensor(2) <= 1

 +  where tensor(2) = abs((31 - tensor(33)))

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

@anteju anteju marked this pull request as ready for review December 20, 2023 21:09
@github-actions github-actions bot added the ASR label Dec 20, 2023
@anteju
Copy link
Collaborator Author

anteju commented Dec 20, 2023

jenkins

Copy link
Collaborator

@titu1994 titu1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !

@anteju anteju merged commit c0ab6be into main Dec 20, 2023
15 checks passed
@anteju anteju deleted the fix/test-rnnt-decoding branch December 20, 2023 23:36
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
…#8067)

* Increase length check tolerance to prevent test failing

Signed-off-by: Ante Jukić <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
…#8067)

* Increase length check tolerance to prevent test failing

Signed-off-by: Ante Jukić <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
…#8067)

* Increase length check tolerance to prevent test failing

Signed-off-by: Ante Jukić <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants