Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various issues with broken links and bugs #8064

Merged
merged 2 commits into from
Dec 20, 2023

Conversation

titu1994
Copy link
Collaborator

What does this PR do ?

Collection: [ASR, NLP, TTS]

Changelog

Fixes bugs and typos in

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

Copy link
Collaborator

@athitten athitten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@titu1994 titu1994 merged commit 8459503 into NVIDIA:r1.22.0 Dec 20, 2023
8 checks passed
@titu1994 titu1994 deleted the fix_typos branch December 20, 2023 20:05
github-actions bot pushed a commit that referenced this pull request Dec 20, 2023
* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
titu1994 added a commit to titu1994/NeMo that referenced this pull request Dec 20, 2023
* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
titu1994 added a commit that referenced this pull request Dec 20, 2023
* Fix various issues with broken links and bugs (#8064)

* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>

* Update branch for main

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
* Fix various issues with broken links and bugs (NVIDIA#8064)

* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>

* Update branch for main

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
* Fix various issues with broken links and bugs (NVIDIA#8064)

* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>

* Update branch for main

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
* Fix various issues with broken links and bugs (NVIDIA#8064)

* Fix ASR CTC notebook to use HuggingFace Datasets

Signed-off-by: smajumdar <[email protected]>

* Various fixes

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>

* Update branch for main

Signed-off-by: smajumdar <[email protected]>

---------

Signed-off-by: smajumdar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants