Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore O2 FP16/BF16 wrapper for GPT #8035

Closed
wants to merge 1 commit into from

Conversation

timmoon10
Copy link
Collaborator

What does this PR do ?

When running GPT with O2 enabled, I am seeing errors at the following line since _wrap_model_for_O2 is not defined:

This function was removed in #7814. I see that this PR added the function to BERT, so could this be a bug?

Collection: NLP

Changelog

  • Restore _wrap_model_for_O2 function in GPT

Usage

Run GPT, e.g. with the config at https://github.com/NVIDIA/NeMo/blob/main/examples/nlp/language_modeling/conf/megatron_gpt_config.yaml, and set model.megatron_amp_O2=True

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Pinging @shanmugamr1992

Additional Information

@timmoon10 timmoon10 added the bug Something isn't working label Dec 15, 2023
@github-actions github-actions bot added the NLP label Dec 15, 2023
@timmoon10
Copy link
Collaborator Author

Closed by #8038.

@timmoon10 timmoon10 closed this Dec 18, 2023
@timmoon10 timmoon10 deleted the gpt-o2-bugfix branch December 18, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working NLP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant