Temporary pin Lightning-Utilities version due to broken NamedTuple #8022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vladimir Bataev <[email protected]>
for more information, see https://pre-commit.ci
|
jenkins |
titu1994
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Fyi @athitten @ericharper We are pinning this due to issues with tutorial, i believe main branch should also be pinned for the time being while we discuss with PTL how to resolve this safely.
|
@titu1994 It seem to be a know issue, hope will be fixed soon Lightning-AI/utilities#196 |
|
Merging for now - fyi @ericharper @athitten |
github-actions bot
pushed a commit
that referenced
this pull request
Dec 18, 2023
…8022) * Pin lightning-utilities package Signed-off-by: Vladimir Bataev <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Vladimir Bataev <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
Don't merge this to main for now (unless Eric or @athitten gives the go ahead for main) |
|
@titu1994 The issue is fixed in Lightning-Utilities in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Pin Lightning-Utitilies package version due to broken NamedTuple in
0.10.0Lightning-AI/utilities#160 introduced the issue,
https://github.com/Lightning-AI/utilities/blob/a00e1144dd300e3bc2fc8746a8e85510ffe35aa7/src/lightning_utilities/core/apply_func.py#L67 here NamedTuple force converted to tuple.
This fixes the bug https://nvbugspro.nvidia.com/bug/4405798 (broken
ASR_TTS_Tutorial)Collection: [Note which collection this PR will affect]
Changelog
Usage
# Add a code snippet demonstrating how to use thisJenkins CI
To run Jenkins, a NeMo User with write access must comment
jenkinson the PR.Before your PR is "Ready for review"
Pre checks:
PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.
Who can review?
Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.
Additional Information