Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update link to yaml file in ASR_with_Transducers.ipynb #8014

Merged
merged 1 commit into from
Dec 12, 2023

Conversation

Faith-Nchifor
Copy link
Contributor

changed link from ../../examples/asr/conf/contextnet_rnnt/contextnet_rnnt.yaml to /content/configs/contextnet_rnnt.yaml because the latter did not exist and threw and error when trying to load the yaml config file.

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Collection: [Note which collection this PR will affect]

Changelog

  • Add specific line by line info of high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Jenkins CI

To run Jenkins, a NeMo User with write access must comment jenkins on the PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

PR Type:

  • New Feature
  • Bugfix
  • Documentation

If you haven't finished some of the above items you can still open "Draft" PR.

Who can review?

Anyone in the community is free to review the PR once the checks have passed.
Contributor guidelines contains specific people who can review PRs to various areas.

Additional Information

  • Related to # (issue)

changed link from `../../examples/asr/conf/contextnet_rnnt/contextnet_rnnt.yaml` to `/content/configs/contextnet_rnnt.yaml` because the latter did not exist and threw and error when trying to load the yaml config file.

Signed-off-by: Faith Wenyi Nchifor <[email protected]>
@github-actions github-actions bot added the ASR label Dec 12, 2023
@titu1994 titu1994 merged commit 47f6773 into NVIDIA:main Dec 12, 2023
4 checks passed
pzelasko pushed a commit to pzelasko/NeMo that referenced this pull request Jan 3, 2024
changed link from `../../examples/asr/conf/contextnet_rnnt/contextnet_rnnt.yaml` to `/content/configs/contextnet_rnnt.yaml` because the latter did not exist and threw and error when trying to load the yaml config file.

Signed-off-by: Faith Wenyi Nchifor <[email protected]>
Signed-off-by: Piotr Żelasko <[email protected]>
ssh-meister pushed a commit to ssh-meister/NeMo that referenced this pull request Feb 15, 2024
changed link from `../../examples/asr/conf/contextnet_rnnt/contextnet_rnnt.yaml` to `/content/configs/contextnet_rnnt.yaml` because the latter did not exist and threw and error when trying to load the yaml config file.

Signed-off-by: Faith Wenyi Nchifor <[email protected]>
Signed-off-by: Sasha Meister <[email protected]>
rohitrango pushed a commit to rohitrango/NeMo that referenced this pull request Jun 25, 2024
changed link from `../../examples/asr/conf/contextnet_rnnt/contextnet_rnnt.yaml` to `/content/configs/contextnet_rnnt.yaml` because the latter did not exist and threw and error when trying to load the yaml config file.

Signed-off-by: Faith Wenyi Nchifor <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants